tei/MapLibreParticleLab
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[core] Get rid of ::unref() for Timer and AsyncTask

Browse Source 
Not need, legacy from libuv. The RunLoop keep the main
loop running until is explicitly no longer needed.
This commit is contained in:
Thiago Marcos P. Santos
2016-01-08 23:17:43 +02:00
parent e7b0b31d58
commit d7fdcc73bf
11 changed files with 31 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
test/miscellaneous/timer.cpp
View File

@@ -12,7 +12,6 @@ TEST(Timer, Basic) {
RunLoop loop;
Timer timer;
timer.unref();
auto callback = [&loop] { loop.stop(); };
@@ -38,7 +37,6 @@ TEST(Timer, Repeat) {
RunLoop loop;
Timer timer;
timer.unref();
unsigned count = 10;
auto callback = [&] {
@@ -66,10 +64,7 @@ TEST(Timer, Stop) {
RunLoop loop;
Timer timer1;
timer1.unref();
Timer timer2;
timer2.unref();
auto interval1 = std::chrono::milliseconds(50);
auto interval2 = std::chrono::milliseconds(250);
@@ -106,10 +101,7 @@ TEST(Timer, DestroyShouldStop) {
RunLoop loop;
auto timer1 = std::make_unique<Timer>();
timer1->unref();
Timer timer2;
timer2.unref();
auto interval1 = std::chrono::milliseconds(50);
auto interval2 = std::chrono::milliseconds(250);
@@ -146,7 +138,6 @@ TEST(Timer, StartOverrides) {
RunLoop loop;
Timer timer;
timer.unref();
auto interval1 = std::chrono::milliseconds(50);
auto interval2 = std::chrono::milliseconds(250);
@@ -182,6 +173,5 @@ TEST(Timer, CanStopNonStartedTimer) {
RunLoop loop;
Timer timer;
timer.unref();
timer.stop();
}