[core] Get rid of ::unref() for Timer and AsyncTask

Not need, legacy from libuv. The RunLoop keep the main
loop running until is explicitly no longer needed.
This commit is contained in:
Thiago Marcos P. Santos
2016-01-08 23:17:43 +02:00
parent e7b0b31d58
commit d7fdcc73bf
11 changed files with 31 additions and 38 deletions

View File

@@ -18,7 +18,6 @@ public:
MockFileSource::MockFileSource(Type type_, const std::string& match_)
: type(type_), match(match_) {
timer.unref();
timer.start(std::chrono::milliseconds(10), std::chrono::milliseconds(10), [this] {
// Explicit move to avoid iterator invalidation if ~MockFileRequest gets called within the loop.
auto pending_ = std::move(pending);

View File

@@ -40,7 +40,6 @@ TEST(AsyncTask, RequestCoalescing) {
unsigned count = 0;
AsyncTask async([&count] { ++count; });
async.unref();
async.send();
async.send();
@@ -70,7 +69,6 @@ TEST(AsyncTask, RequestCoalescingMultithreaded) {
unsigned count = 0;
AsyncTask async([&count] { ++count; });
async.unref();
std::vector<std::unique_ptr<Thread<TestWorker>>> threads;
ThreadContext context = {"Test", ThreadType::Map, ThreadPriority::Regular};
@@ -97,7 +95,6 @@ TEST(AsyncTask, ThreadSafety) {
unsigned count = 0;
AsyncTask async([&count] { ++count; });
async.unref();
unsigned numThreads = 25;

View File

@@ -12,7 +12,6 @@ TEST(Timer, Basic) {
RunLoop loop;
Timer timer;
timer.unref();
auto callback = [&loop] { loop.stop(); };
@@ -38,7 +37,6 @@ TEST(Timer, Repeat) {
RunLoop loop;
Timer timer;
timer.unref();
unsigned count = 10;
auto callback = [&] {
@@ -66,10 +64,7 @@ TEST(Timer, Stop) {
RunLoop loop;
Timer timer1;
timer1.unref();
Timer timer2;
timer2.unref();
auto interval1 = std::chrono::milliseconds(50);
auto interval2 = std::chrono::milliseconds(250);
@@ -106,10 +101,7 @@ TEST(Timer, DestroyShouldStop) {
RunLoop loop;
auto timer1 = std::make_unique<Timer>();
timer1->unref();
Timer timer2;
timer2.unref();
auto interval1 = std::chrono::milliseconds(50);
auto interval2 = std::chrono::milliseconds(250);
@@ -146,7 +138,6 @@ TEST(Timer, StartOverrides) {
RunLoop loop;
Timer timer;
timer.unref();
auto interval1 = std::chrono::milliseconds(50);
auto interval2 = std::chrono::milliseconds(250);
@@ -182,6 +173,5 @@ TEST(Timer, CanStopNonStartedTimer) {
RunLoop loop;
Timer timer;
timer.unref();
timer.stop();
}

View File

@@ -33,7 +33,6 @@ TEST_P(PendingResources, DeleteMapObjectWithPendingRequest) {
loop.stop();
});
endTest.unref();
fileSource.requestEnqueuedCallback = [&endTest] { endTest.send(); };
const std::string style = util::read_file("test/fixtures/resources/style.json");