diff --git a/cmake/core-files.cmake b/cmake/core-files.cmake index 17498ec42..9513c0181 100644 --- a/cmake/core-files.cmake +++ b/cmake/core-files.cmake @@ -162,8 +162,12 @@ set(MBGL_CORE_FILES src/mbgl/renderer/bucket.hpp src/mbgl/renderer/bucket_parameters.cpp src/mbgl/renderer/bucket_parameters.hpp + src/mbgl/renderer/cascade_parameters.hpp src/mbgl/renderer/circle_bucket.cpp src/mbgl/renderer/circle_bucket.hpp + src/mbgl/renderer/cross_faded_property_evaluator.cpp + src/mbgl/renderer/cross_faded_property_evaluator.hpp + src/mbgl/renderer/data_driven_property_evaluator.hpp src/mbgl/renderer/debug_bucket.cpp src/mbgl/renderer/debug_bucket.hpp src/mbgl/renderer/fill_bucket.cpp @@ -177,6 +181,8 @@ set(MBGL_CORE_FILES src/mbgl/renderer/line_bucket.cpp src/mbgl/renderer/line_bucket.hpp src/mbgl/renderer/paint_parameters.hpp + src/mbgl/renderer/paint_property_binder.hpp + src/mbgl/renderer/paint_property_statistics.hpp src/mbgl/renderer/painter.cpp src/mbgl/renderer/painter.hpp src/mbgl/renderer/painter_background.cpp @@ -188,6 +194,9 @@ set(MBGL_CORE_FILES src/mbgl/renderer/painter_line.cpp src/mbgl/renderer/painter_raster.cpp src/mbgl/renderer/painter_symbol.cpp + src/mbgl/renderer/possibly_evaluated_property_value.hpp + src/mbgl/renderer/property_evaluation_parameters.hpp + src/mbgl/renderer/property_evaluator.hpp src/mbgl/renderer/raster_bucket.cpp src/mbgl/renderer/raster_bucket.hpp src/mbgl/renderer/render_background_layer.cpp @@ -203,22 +212,25 @@ set(MBGL_CORE_FILES src/mbgl/renderer/render_item.hpp src/mbgl/renderer/render_layer.cpp src/mbgl/renderer/render_layer.hpp + src/mbgl/renderer/render_light.hpp src/mbgl/renderer/render_line_layer.cpp src/mbgl/renderer/render_line_layer.hpp src/mbgl/renderer/render_pass.hpp src/mbgl/renderer/render_raster_layer.cpp src/mbgl/renderer/render_raster_layer.hpp - src/mbgl/renderer/render_symbol_layer.cpp - src/mbgl/renderer/render_symbol_layer.hpp src/mbgl/renderer/render_source.cpp src/mbgl/renderer/render_source.hpp src/mbgl/renderer/render_source_observer.hpp + src/mbgl/renderer/render_symbol_layer.cpp + src/mbgl/renderer/render_symbol_layer.hpp src/mbgl/renderer/render_tile.cpp src/mbgl/renderer/render_tile.hpp src/mbgl/renderer/symbol_bucket.cpp src/mbgl/renderer/symbol_bucket.hpp src/mbgl/renderer/tile_pyramid.cpp src/mbgl/renderer/tile_pyramid.hpp + src/mbgl/renderer/transitioning_property.hpp + src/mbgl/renderer/update_parameters.hpp # renderer/sources src/mbgl/renderer/sources/render_geojson_source.cpp @@ -305,28 +317,18 @@ set(MBGL_CORE_FILES include/mbgl/style/transition_options.hpp include/mbgl/style/types.hpp include/mbgl/style/undefined.hpp - src/mbgl/style/cascade_parameters.hpp src/mbgl/style/class_dictionary.cpp src/mbgl/style/class_dictionary.hpp - src/mbgl/style/cross_faded_property_evaluator.cpp - src/mbgl/style/cross_faded_property_evaluator.hpp - src/mbgl/style/data_driven_property_evaluator.hpp src/mbgl/style/image.cpp src/mbgl/style/layer.cpp src/mbgl/style/layer_impl.cpp src/mbgl/style/layer_impl.hpp src/mbgl/style/layer_observer.hpp src/mbgl/style/layout_property.hpp - src/mbgl/style/light_impl.hpp src/mbgl/style/observer.hpp src/mbgl/style/paint_property.hpp - src/mbgl/style/paint_property_binder.hpp - src/mbgl/style/paint_property_statistics.hpp src/mbgl/style/parser.cpp src/mbgl/style/parser.hpp - src/mbgl/style/possibly_evaluated_property_value.hpp - src/mbgl/style/property_evaluation_parameters.hpp - src/mbgl/style/property_evaluator.hpp src/mbgl/style/rapidjson_conversion.hpp src/mbgl/style/source.cpp src/mbgl/style/source_impl.cpp @@ -336,10 +338,8 @@ set(MBGL_CORE_FILES src/mbgl/style/style.hpp src/mbgl/style/tile_source_impl.cpp src/mbgl/style/tile_source_impl.hpp - src/mbgl/style/transitioning_property.hpp src/mbgl/style/types.cpp src/mbgl/style/update_batch.hpp - src/mbgl/style/update_parameters.hpp # style/conversion include/mbgl/style/conversion/constant.hpp diff --git a/src/mbgl/annotation/annotation_tile.cpp b/src/mbgl/annotation/annotation_tile.cpp index fd182b70b..796ca04ba 100644 --- a/src/mbgl/annotation/annotation_tile.cpp +++ b/src/mbgl/annotation/annotation_tile.cpp @@ -2,7 +2,7 @@ #include #include #include -#include +#include #include #include @@ -10,7 +10,7 @@ namespace mbgl { AnnotationTile::AnnotationTile(const OverscaledTileID& overscaledTileID, - const style::UpdateParameters& parameters) + const UpdateParameters& parameters) : GeometryTile(overscaledTileID, AnnotationManager::SourceID, parameters, *parameters.style.glyphAtlas, parameters.annotationManager.spriteAtlas), diff --git a/src/mbgl/annotation/annotation_tile.hpp b/src/mbgl/annotation/annotation_tile.hpp index 2c100ed50..6ca9079f9 100644 --- a/src/mbgl/annotation/annotation_tile.hpp +++ b/src/mbgl/annotation/annotation_tile.hpp @@ -7,15 +7,12 @@ namespace mbgl { class AnnotationManager; - -namespace style { class UpdateParameters; -} // namespace style class AnnotationTile : public GeometryTile { public: AnnotationTile(const OverscaledTileID&, - const style::UpdateParameters&); + const UpdateParameters&); ~AnnotationTile() override; void setNecessity(Necessity) final; diff --git a/src/mbgl/annotation/render_annotation_source.hpp b/src/mbgl/annotation/render_annotation_source.hpp index 394acc510..ae0a43c5c 100644 --- a/src/mbgl/annotation/render_annotation_source.hpp +++ b/src/mbgl/annotation/render_annotation_source.hpp @@ -14,7 +14,7 @@ public: // Called when the camera has changed. May load new tiles, unload obsolete tiles, or // trigger re-placement of existing complete tiles. - void updateTiles(const style::UpdateParameters&) final; + void updateTiles(const UpdateParameters&) final; // Removes all tiles (by putting them into the cache). void removeTiles() final; diff --git a/src/mbgl/map/map.cpp b/src/mbgl/map/map.cpp index 46ccc7216..9964c5c9f 100644 --- a/src/mbgl/map/map.cpp +++ b/src/mbgl/map/map.cpp @@ -12,7 +12,7 @@ #include #include #include -#include +#include #include #include #include @@ -253,7 +253,7 @@ void Map::Impl::render(View& view) { style->relayout(); } - style::UpdateParameters parameters(pixelRatio, + UpdateParameters parameters(pixelRatio, debugOptions, transform.getState(), scheduler, diff --git a/src/mbgl/programs/fill_extrusion_program.cpp b/src/mbgl/programs/fill_extrusion_program.cpp index 67426c8d9..63d1cbeb5 100644 --- a/src/mbgl/programs/fill_extrusion_program.cpp +++ b/src/mbgl/programs/fill_extrusion_program.cpp @@ -1,6 +1,6 @@ #include #include -#include +#include #include #include #include diff --git a/src/mbgl/programs/fill_extrusion_program.hpp b/src/mbgl/programs/fill_extrusion_program.hpp index b84e50298..48fca44ee 100644 --- a/src/mbgl/programs/fill_extrusion_program.hpp +++ b/src/mbgl/programs/fill_extrusion_program.hpp @@ -10,7 +10,7 @@ #include #include #include -#include +#include #include @@ -19,10 +19,7 @@ namespace mbgl { class SpriteAtlasElement; class UnwrappedTileID; class TransformState; - -namespace style { template class Faded; -} // namespace style namespace uniforms { MBGL_DEFINE_UNIFORM_VECTOR(float, 3, u_lightpos); @@ -45,7 +42,7 @@ struct FillExtrusionUniforms : gl::Uniforms< { static Values values(mat4, const TransformState&, - const style::EvaluatedLight&); + const EvaluatedLight&); }; struct FillExtrusionPatternUniforms : gl::Uniforms< @@ -71,11 +68,11 @@ struct FillExtrusionPatternUniforms : gl::Uniforms< static Values values(mat4, const SpriteAtlasElement&, const SpriteAtlasElement&, - const style::Faded&, + const Faded&, const UnwrappedTileID&, const TransformState&, const float, - const style::EvaluatedLight&); + const EvaluatedLight&); }; class FillExtrusionProgram : public Program< diff --git a/src/mbgl/programs/fill_program.cpp b/src/mbgl/programs/fill_program.cpp index eebcffd2c..4310f0116 100644 --- a/src/mbgl/programs/fill_program.cpp +++ b/src/mbgl/programs/fill_program.cpp @@ -1,6 +1,6 @@ #include #include -#include +#include #include #include diff --git a/src/mbgl/programs/fill_program.hpp b/src/mbgl/programs/fill_program.hpp index bbf5c39fb..63751e740 100644 --- a/src/mbgl/programs/fill_program.hpp +++ b/src/mbgl/programs/fill_program.hpp @@ -19,10 +19,7 @@ namespace mbgl { class SpriteAtlasElement; class UnwrappedTileID; class TransformState; - -namespace style { template class Faded; -} // namespace style struct FillLayoutAttributes : gl::Attributes< attributes::a_pos> @@ -54,7 +51,7 @@ struct FillPatternUniforms : gl::Uniforms< Size framebufferSize, const SpriteAtlasElement&, const SpriteAtlasElement&, - const style::Faded&, + const Faded&, const UnwrappedTileID&, const TransformState&); }; diff --git a/src/mbgl/programs/symbol_program.hpp b/src/mbgl/programs/symbol_program.hpp index 4895f6fca..1cac99bfc 100644 --- a/src/mbgl/programs/symbol_program.hpp +++ b/src/mbgl/programs/symbol_program.hpp @@ -105,7 +105,7 @@ public: const style::DataDrivenPropertyValue& sizeProperty, const float defaultValue); - virtual SymbolSizeAttributes::Bindings attributeBindings(const style::PossiblyEvaluatedPropertyValue currentValue) const = 0; + virtual SymbolSizeAttributes::Bindings attributeBindings(const PossiblyEvaluatedPropertyValue currentValue) const = 0; virtual void populateVertexVector(const GeometryTileFeature& feature) = 0; virtual UniformValues uniformValues(float currentZoom) const = 0; virtual void upload(gl::Context&) = 0; @@ -155,7 +155,7 @@ public: ); } - SymbolSizeAttributes::Bindings attributeBindings(const style::PossiblyEvaluatedPropertyValue) const override { + SymbolSizeAttributes::Bindings attributeBindings(const PossiblyEvaluatedPropertyValue) const override { return SymbolSizeAttributes::Bindings { SymbolSizeAttributes::Attribute::ConstantBinding {{{0, 0, 0}}} }; } void upload(gl::Context&) override {} @@ -209,7 +209,7 @@ public: defaultValue(defaultValue_) { } - SymbolSizeAttributes::Bindings attributeBindings(const style::PossiblyEvaluatedPropertyValue currentValue) const override { + SymbolSizeAttributes::Bindings attributeBindings(const PossiblyEvaluatedPropertyValue currentValue) const override { if (currentValue.isConstant()) { return SymbolSizeAttributes::Bindings { SymbolSizeAttributes::Attribute::ConstantBinding {{{0, 0, 0}}} }; } @@ -266,7 +266,7 @@ public: return getCoveringStops(stops, tileZoom, tileZoom + 1); })) {} - SymbolSizeAttributes::Bindings attributeBindings(const style::PossiblyEvaluatedPropertyValue currentValue) const override { + SymbolSizeAttributes::Bindings attributeBindings(const PossiblyEvaluatedPropertyValue currentValue) const override { if (currentValue.isConstant()) { return SymbolSizeAttributes::Bindings { SymbolSizeAttributes::Attribute::ConstantBinding {{{0, 0, 0}}} }; } @@ -361,7 +361,7 @@ public: UniformValues&& uniformValues, const gl::VertexBuffer& layoutVertexBuffer, const SymbolSizeBinder& symbolSizeBinder, - const style::PossiblyEvaluatedPropertyValue& currentSizeValue, + const PossiblyEvaluatedPropertyValue& currentSizeValue, const gl::IndexBuffer& indexBuffer, const gl::SegmentVector& segments, const PaintPropertyBinders& paintPropertyBinders, diff --git a/src/mbgl/style/cascade_parameters.hpp b/src/mbgl/renderer/cascade_parameters.hpp similarity index 69% rename from src/mbgl/style/cascade_parameters.hpp rename to src/mbgl/renderer/cascade_parameters.hpp index e0333741d..4096cc5a6 100644 --- a/src/mbgl/style/cascade_parameters.hpp +++ b/src/mbgl/renderer/cascade_parameters.hpp @@ -7,14 +7,12 @@ #include namespace mbgl { -namespace style { class CascadeParameters { public: - std::vector classes; + std::vector classes; TimePoint now; - TransitionOptions transition; + style::TransitionOptions transition; }; -} // namespace style } // namespace mbgl diff --git a/src/mbgl/style/cross_faded_property_evaluator.cpp b/src/mbgl/renderer/cross_faded_property_evaluator.cpp similarity index 82% rename from src/mbgl/style/cross_faded_property_evaluator.cpp rename to src/mbgl/renderer/cross_faded_property_evaluator.cpp index 796ca00bb..ee3c86614 100644 --- a/src/mbgl/style/cross_faded_property_evaluator.cpp +++ b/src/mbgl/renderer/cross_faded_property_evaluator.cpp @@ -1,13 +1,12 @@ -#include +#include #include #include namespace mbgl { -namespace style { template -Faded CrossFadedPropertyEvaluator::operator()(const Undefined&) const { +Faded CrossFadedPropertyEvaluator::operator()(const style::Undefined&) const { return calculate(defaultValue, defaultValue, defaultValue); } @@ -17,7 +16,7 @@ Faded CrossFadedPropertyEvaluator::operator()(const T& constant) const { } template -Faded CrossFadedPropertyEvaluator::operator()(const CameraFunction& function) const { +Faded CrossFadedPropertyEvaluator::operator()(const style::CameraFunction& function) const { return calculate(function.evaluate(parameters.z - 1.0f), function.evaluate(parameters.z), function.evaluate(parameters.z + 1.0f)); @@ -38,5 +37,4 @@ Faded CrossFadedPropertyEvaluator::calculate(const T& min, const T& mid, c template class CrossFadedPropertyEvaluator; template class CrossFadedPropertyEvaluator>; -} // namespace style } // namespace mbgl diff --git a/src/mbgl/style/cross_faded_property_evaluator.hpp b/src/mbgl/renderer/cross_faded_property_evaluator.hpp similarity index 77% rename from src/mbgl/style/cross_faded_property_evaluator.hpp rename to src/mbgl/renderer/cross_faded_property_evaluator.hpp index c5642f5cf..40ecba5d9 100644 --- a/src/mbgl/style/cross_faded_property_evaluator.hpp +++ b/src/mbgl/renderer/cross_faded_property_evaluator.hpp @@ -1,11 +1,10 @@ #pragma once #include -#include +#include #include namespace mbgl { -namespace style { template class Faded { @@ -26,9 +25,9 @@ public: : parameters(parameters_), defaultValue(std::move(defaultValue_)) {} - Faded operator()(const Undefined&) const; + Faded operator()(const style::Undefined&) const; Faded operator()(const T& constant) const; - Faded operator()(const CameraFunction&) const; + Faded operator()(const style::CameraFunction&) const; private: Faded calculate(const T& min, const T& mid, const T& max) const; @@ -37,11 +36,9 @@ private: T defaultValue; }; -} // namespace style - namespace util { template -struct Interpolator> +struct Interpolator> : Uninterpolated {}; } // namespace util diff --git a/src/mbgl/style/data_driven_property_evaluator.hpp b/src/mbgl/renderer/data_driven_property_evaluator.hpp similarity index 75% rename from src/mbgl/style/data_driven_property_evaluator.hpp rename to src/mbgl/renderer/data_driven_property_evaluator.hpp index 7a0ff9a09..6406b3478 100644 --- a/src/mbgl/style/data_driven_property_evaluator.hpp +++ b/src/mbgl/renderer/data_driven_property_evaluator.hpp @@ -1,11 +1,10 @@ #pragma once #include -#include -#include +#include +#include namespace mbgl { -namespace style { template class DataDrivenPropertyEvaluator { @@ -16,7 +15,7 @@ public: : parameters(parameters_), defaultValue(std::move(defaultValue_)) {} - ResultType operator()(const Undefined&) const { + ResultType operator()(const style::Undefined&) const { return ResultType(defaultValue); } @@ -24,7 +23,7 @@ public: return ResultType(constant); } - ResultType operator()(const CameraFunction& function) const { + ResultType operator()(const style::CameraFunction& function) const { return ResultType(function.evaluate(parameters.z)); } @@ -38,5 +37,4 @@ private: T defaultValue; }; -} // namespace style } // namespace mbgl diff --git a/src/mbgl/style/paint_property_binder.hpp b/src/mbgl/renderer/paint_property_binder.hpp similarity index 95% rename from src/mbgl/style/paint_property_binder.hpp rename to src/mbgl/renderer/paint_property_binder.hpp index 3915ee588..3e53bcc88 100644 --- a/src/mbgl/style/paint_property_binder.hpp +++ b/src/mbgl/renderer/paint_property_binder.hpp @@ -4,10 +4,9 @@ #include #include #include -#include +#include namespace mbgl { -namespace style { /* ZoomInterpolatedAttribute is a 'compound' attribute, representing two values of the @@ -133,7 +132,7 @@ public: using Attribute = ZoomInterpolatedAttributeType; using AttributeBinding = typename Attribute::Binding; - SourceFunctionPaintPropertyBinder(SourceFunction function_, T defaultValue_) + SourceFunctionPaintPropertyBinder(style::SourceFunction function_, T defaultValue_) : function(std::move(function_)), defaultValue(std::move(defaultValue_)) { } @@ -167,7 +166,7 @@ public: } private: - SourceFunction function; + style::SourceFunction function; T defaultValue; gl::VertexVector vertexVector; optional> vertexBuffer; @@ -184,7 +183,7 @@ public: using AttributeBinding = typename Attribute::Binding; using Vertex = gl::detail::Vertex; - CompositeFunctionPaintPropertyBinder(CompositeFunction function_, float zoom, T defaultValue_) + CompositeFunctionPaintPropertyBinder(style::CompositeFunction function_, float zoom, T defaultValue_) : function(std::move(function_)), defaultValue(std::move(defaultValue_)), coveringRanges(function.coveringRanges(zoom)) { @@ -222,8 +221,8 @@ public: } private: - using InnerStops = typename CompositeFunction::InnerStops; - CompositeFunction function; + using InnerStops = typename style::CompositeFunction::InnerStops; + style::CompositeFunction function; T defaultValue; std::tuple, Range> coveringRanges; gl::VertexVector vertexVector; @@ -237,10 +236,10 @@ PaintPropertyBinder::create(const PossiblyEvaluatedPropertyValue& value [&] (const T& constant) -> std::unique_ptr> { return std::make_unique>(constant); }, - [&] (const SourceFunction& function) { + [&] (const style::SourceFunction& function) { return std::make_unique>(function, defaultValue); }, - [&] (const CompositeFunction& function) { + [&] (const style::CompositeFunction& function) { return std::make_unique>(function, zoom, defaultValue); } ); @@ -328,5 +327,4 @@ private: Binders binders; }; -} // namespace style } // namespace mbgl diff --git a/src/mbgl/style/paint_property_statistics.hpp b/src/mbgl/renderer/paint_property_statistics.hpp similarity index 92% rename from src/mbgl/style/paint_property_statistics.hpp rename to src/mbgl/renderer/paint_property_statistics.hpp index 01d634dd6..59a854591 100644 --- a/src/mbgl/style/paint_property_statistics.hpp +++ b/src/mbgl/renderer/paint_property_statistics.hpp @@ -3,7 +3,6 @@ #include namespace mbgl { -namespace style { template class PaintPropertyStatistics { @@ -27,5 +26,4 @@ private: optional _max; }; -} // namespace style } // namespace mbgl diff --git a/src/mbgl/renderer/painter.hpp b/src/mbgl/renderer/painter.hpp index c7c8173d0..ff7274971 100644 --- a/src/mbgl/renderer/painter.hpp +++ b/src/mbgl/renderer/painter.hpp @@ -158,7 +158,7 @@ private: GlyphAtlas* glyphAtlas = nullptr; LineAtlas* lineAtlas = nullptr; - style::EvaluatedLight evaluatedLight; + EvaluatedLight evaluatedLight; FrameHistory frameHistory; diff --git a/src/mbgl/style/possibly_evaluated_property_value.hpp b/src/mbgl/renderer/possibly_evaluated_property_value.hpp similarity index 73% rename from src/mbgl/style/possibly_evaluated_property_value.hpp rename to src/mbgl/renderer/possibly_evaluated_property_value.hpp index 9cb5f6e81..a0bcec2bf 100644 --- a/src/mbgl/style/possibly_evaluated_property_value.hpp +++ b/src/mbgl/renderer/possibly_evaluated_property_value.hpp @@ -7,15 +7,13 @@ namespace mbgl { -namespace style { - template class PossiblyEvaluatedPropertyValue { private: using Value = variant< T, - SourceFunction, - CompositeFunction>; + style::SourceFunction, + style::CompositeFunction>; Value value; @@ -46,25 +44,23 @@ public: T evaluate(const Feature& feature, float zoom, T defaultValue) const { return this->match( [&] (const T& constant) { return constant; }, - [&] (const SourceFunction& function) { + [&] (const style::SourceFunction& function) { return function.evaluate(feature, defaultValue); }, - [&] (const CompositeFunction& function) { + [&] (const style::CompositeFunction& function) { return function.evaluate(zoom, feature, defaultValue); } ); } }; -} // namespace style - namespace util { template -struct Interpolator> { - style::PossiblyEvaluatedPropertyValue operator()(const style::PossiblyEvaluatedPropertyValue& a, - const style::PossiblyEvaluatedPropertyValue& b, - const double t) const { +struct Interpolator> { + PossiblyEvaluatedPropertyValue operator()(const PossiblyEvaluatedPropertyValue& a, + const PossiblyEvaluatedPropertyValue& b, + const double t) const { if (a.isConstant() && b.isConstant()) { return { interpolate(*a.constant(), *b.constant(), t) }; } else { diff --git a/src/mbgl/style/property_evaluation_parameters.hpp b/src/mbgl/renderer/property_evaluation_parameters.hpp similarity index 94% rename from src/mbgl/style/property_evaluation_parameters.hpp rename to src/mbgl/renderer/property_evaluation_parameters.hpp index 2591fc07a..b18fe57ac 100644 --- a/src/mbgl/style/property_evaluation_parameters.hpp +++ b/src/mbgl/renderer/property_evaluation_parameters.hpp @@ -4,7 +4,6 @@ #include namespace mbgl { -namespace style { class PropertyEvaluationParameters { public: @@ -26,5 +25,4 @@ public: Duration defaultFadeDuration; }; -} // namespace style } // namespace mbgl diff --git a/src/mbgl/style/property_evaluator.hpp b/src/mbgl/renderer/property_evaluator.hpp similarity index 66% rename from src/mbgl/style/property_evaluator.hpp rename to src/mbgl/renderer/property_evaluator.hpp index 3f629ada4..3ac057392 100644 --- a/src/mbgl/style/property_evaluator.hpp +++ b/src/mbgl/renderer/property_evaluator.hpp @@ -1,10 +1,9 @@ #pragma once #include -#include +#include namespace mbgl { -namespace style { template class PropertyEvaluator { @@ -15,14 +14,13 @@ public: : parameters(parameters_), defaultValue(std::move(defaultValue_)) {} - T operator()(const Undefined&) const { return defaultValue; } + T operator()(const style::Undefined&) const { return defaultValue; } T operator()(const T& constant) const { return constant; } - T operator()(const CameraFunction& fn) const { return fn.evaluate(parameters.z); } + T operator()(const style::CameraFunction& fn) const { return fn.evaluate(parameters.z); } private: const PropertyEvaluationParameters& parameters; T defaultValue; }; -} // namespace style } // namespace mbgl diff --git a/src/mbgl/renderer/render_background_layer.cpp b/src/mbgl/renderer/render_background_layer.cpp index 5b9821097..a6b4a5e36 100644 --- a/src/mbgl/renderer/render_background_layer.cpp +++ b/src/mbgl/renderer/render_background_layer.cpp @@ -19,11 +19,11 @@ std::unique_ptr RenderBackgroundLayer::createBucket(const BucketParamete return nullptr; } -void RenderBackgroundLayer::cascade(const style::CascadeParameters ¶meters) { +void RenderBackgroundLayer::cascade(const CascadeParameters ¶meters) { unevaluated = impl->cascading.cascade(parameters, std::move(unevaluated)); } -bool RenderBackgroundLayer::evaluate(const style::PropertyEvaluationParameters ¶meters) { +bool RenderBackgroundLayer::evaluate(const PropertyEvaluationParameters ¶meters) { evaluated = unevaluated.evaluate(parameters); passes = evaluated.get() > 0 ? RenderPass::Translucent diff --git a/src/mbgl/renderer/render_background_layer.hpp b/src/mbgl/renderer/render_background_layer.hpp index bd74f7b39..137980389 100644 --- a/src/mbgl/renderer/render_background_layer.hpp +++ b/src/mbgl/renderer/render_background_layer.hpp @@ -14,8 +14,8 @@ public: std::unique_ptr clone() const override; - void cascade(const style::CascadeParameters&) override; - bool evaluate(const style::PropertyEvaluationParameters&) override; + void cascade(const CascadeParameters&) override; + bool evaluate(const PropertyEvaluationParameters&) override; std::unique_ptr createBucket(const BucketParameters&, const std::vector&) const override; diff --git a/src/mbgl/renderer/render_circle_layer.cpp b/src/mbgl/renderer/render_circle_layer.cpp index aa127e985..56832d53c 100644 --- a/src/mbgl/renderer/render_circle_layer.cpp +++ b/src/mbgl/renderer/render_circle_layer.cpp @@ -20,11 +20,11 @@ std::unique_ptr RenderCircleLayer::createBucket(const BucketParameters& return std::make_unique(parameters, layers); } -void RenderCircleLayer::cascade(const style::CascadeParameters& parameters) { +void RenderCircleLayer::cascade(const CascadeParameters& parameters) { unevaluated = impl->cascading.cascade(parameters, std::move(unevaluated)); } -bool RenderCircleLayer::evaluate(const style::PropertyEvaluationParameters& parameters) { +bool RenderCircleLayer::evaluate(const PropertyEvaluationParameters& parameters) { evaluated = unevaluated.evaluate(parameters); passes = ((evaluated.get().constantOr(1) > 0 || diff --git a/src/mbgl/renderer/render_circle_layer.hpp b/src/mbgl/renderer/render_circle_layer.hpp index 5117b1224..8a2f73ec8 100644 --- a/src/mbgl/renderer/render_circle_layer.hpp +++ b/src/mbgl/renderer/render_circle_layer.hpp @@ -14,8 +14,8 @@ public: std::unique_ptr clone() const override; - void cascade(const style::CascadeParameters&) override; - bool evaluate(const style::PropertyEvaluationParameters&) override; + void cascade(const CascadeParameters&) override; + bool evaluate(const PropertyEvaluationParameters&) override; bool queryIntersectsFeature( const GeometryCoordinates&, diff --git a/src/mbgl/renderer/render_custom_layer.cpp b/src/mbgl/renderer/render_custom_layer.cpp index f9dda47d7..d500d11f4 100644 --- a/src/mbgl/renderer/render_custom_layer.cpp +++ b/src/mbgl/renderer/render_custom_layer.cpp @@ -13,7 +13,7 @@ std::unique_ptr RenderCustomLayer::clone() const { return std::make_unique(*this); } -bool RenderCustomLayer::evaluate(const style::PropertyEvaluationParameters&) { +bool RenderCustomLayer::evaluate(const PropertyEvaluationParameters&) { passes = RenderPass::Translucent; return false; } diff --git a/src/mbgl/renderer/render_custom_layer.hpp b/src/mbgl/renderer/render_custom_layer.hpp index 3c6c06ff7..cb728fecb 100644 --- a/src/mbgl/renderer/render_custom_layer.hpp +++ b/src/mbgl/renderer/render_custom_layer.hpp @@ -13,8 +13,8 @@ public: std::unique_ptr clone() const override; - void cascade(const style::CascadeParameters&) final {} - bool evaluate(const style::PropertyEvaluationParameters&) final; + void cascade(const CascadeParameters&) final {} + bool evaluate(const PropertyEvaluationParameters&) final; std::unique_ptr createBucket(const BucketParameters&, const std::vector&) const final; diff --git a/src/mbgl/renderer/render_fill_extrusion_layer.cpp b/src/mbgl/renderer/render_fill_extrusion_layer.cpp index 8df0d3690..70ee74b56 100644 --- a/src/mbgl/renderer/render_fill_extrusion_layer.cpp +++ b/src/mbgl/renderer/render_fill_extrusion_layer.cpp @@ -20,11 +20,11 @@ std::unique_ptr RenderFillExtrusionLayer::createBucket(const BucketParam return std::make_unique(parameters, layers); } -void RenderFillExtrusionLayer::cascade(const style::CascadeParameters& parameters) { +void RenderFillExtrusionLayer::cascade(const CascadeParameters& parameters) { unevaluated = impl->cascading.cascade(parameters, std::move(unevaluated)); } -bool RenderFillExtrusionLayer::evaluate(const style::PropertyEvaluationParameters& parameters) { +bool RenderFillExtrusionLayer::evaluate(const PropertyEvaluationParameters& parameters) { evaluated = unevaluated.evaluate(parameters); passes = (evaluated.get() > 0) ? RenderPass::Translucent diff --git a/src/mbgl/renderer/render_fill_extrusion_layer.hpp b/src/mbgl/renderer/render_fill_extrusion_layer.hpp index 87b6ad607..b4fd1411f 100644 --- a/src/mbgl/renderer/render_fill_extrusion_layer.hpp +++ b/src/mbgl/renderer/render_fill_extrusion_layer.hpp @@ -14,8 +14,8 @@ public: std::unique_ptr clone() const override; - void cascade(const style::CascadeParameters&) override; - bool evaluate(const style::PropertyEvaluationParameters&) override; + void cascade(const CascadeParameters&) override; + bool evaluate(const PropertyEvaluationParameters&) override; bool queryIntersectsFeature( const GeometryCoordinates&, diff --git a/src/mbgl/renderer/render_fill_layer.cpp b/src/mbgl/renderer/render_fill_layer.cpp index 126189fc5..53c1ff303 100644 --- a/src/mbgl/renderer/render_fill_layer.cpp +++ b/src/mbgl/renderer/render_fill_layer.cpp @@ -20,11 +20,11 @@ std::unique_ptr RenderFillLayer::createBucket(const BucketParameters& pa return std::make_unique(parameters, layers); } -void RenderFillLayer::cascade(const style::CascadeParameters& parameters) { +void RenderFillLayer::cascade(const CascadeParameters& parameters) { unevaluated = impl->cascading.cascade(parameters, std::move(unevaluated)); } -bool RenderFillLayer::evaluate(const style::PropertyEvaluationParameters& parameters) { +bool RenderFillLayer::evaluate(const PropertyEvaluationParameters& parameters) { evaluated = unevaluated.evaluate(parameters); if (unevaluated.get().isUndefined()) { diff --git a/src/mbgl/renderer/render_fill_layer.hpp b/src/mbgl/renderer/render_fill_layer.hpp index 25b969d4c..3a8de3622 100644 --- a/src/mbgl/renderer/render_fill_layer.hpp +++ b/src/mbgl/renderer/render_fill_layer.hpp @@ -14,8 +14,8 @@ public: std::unique_ptr clone() const override; - void cascade(const style::CascadeParameters&) override; - bool evaluate(const style::PropertyEvaluationParameters&) override; + void cascade(const CascadeParameters&) override; + bool evaluate(const PropertyEvaluationParameters&) override; bool queryIntersectsFeature( const GeometryCoordinates&, diff --git a/src/mbgl/renderer/render_layer.hpp b/src/mbgl/renderer/render_layer.hpp index af5345d5e..003059005 100644 --- a/src/mbgl/renderer/render_layer.hpp +++ b/src/mbgl/renderer/render_layer.hpp @@ -12,11 +12,8 @@ namespace mbgl { class Bucket; class BucketParameters; - -namespace style { class CascadeParameters; class PropertyEvaluationParameters; -} // namespace style class RenderLayer { @@ -33,11 +30,11 @@ public: virtual std::unique_ptr clone() const = 0; // Partially evaluate paint properties based on a set of classes. - virtual void cascade(const style::CascadeParameters&) = 0; + virtual void cascade(const CascadeParameters&) = 0; // Fully evaluate cascaded paint properties based on a zoom level. // Returns true if any paint properties have active transitions. - virtual bool evaluate(const style::PropertyEvaluationParameters&) = 0; + virtual bool evaluate(const PropertyEvaluationParameters&) = 0; // Check whether this layer is of the given subtype. template diff --git a/src/mbgl/style/light_impl.hpp b/src/mbgl/renderer/render_light.hpp similarity index 84% rename from src/mbgl/style/light_impl.hpp rename to src/mbgl/renderer/render_light.hpp index d1825090f..8f5929955 100644 --- a/src/mbgl/style/light_impl.hpp +++ b/src/mbgl/renderer/render_light.hpp @@ -1,14 +1,13 @@ #pragma once #include -#include -#include -#include -#include +#include +#include +#include +#include #include namespace mbgl { -namespace style { template class Transitioning; @@ -67,8 +66,7 @@ public: } {} }; -using TransitioningLight = Transitioning; -using EvaluatedLight = Evaluated; +using TransitioningLight = Transitioning; +using EvaluatedLight = Evaluated; -} // namespace style } // namespace mbgl diff --git a/src/mbgl/renderer/render_line_layer.cpp b/src/mbgl/renderer/render_line_layer.cpp index 551d40bef..e5060af79 100644 --- a/src/mbgl/renderer/render_line_layer.cpp +++ b/src/mbgl/renderer/render_line_layer.cpp @@ -20,11 +20,11 @@ std::unique_ptr RenderLineLayer::createBucket(const BucketParameters& pa return std::make_unique(parameters, layers, impl->layout); } -void RenderLineLayer::cascade(const style::CascadeParameters& parameters) { +void RenderLineLayer::cascade(const CascadeParameters& parameters) { unevaluated = impl->cascading.cascade(parameters, std::move(unevaluated)); } -bool RenderLineLayer::evaluate(const style::PropertyEvaluationParameters& parameters) { +bool RenderLineLayer::evaluate(const PropertyEvaluationParameters& parameters) { // for scaling dasharrays auto dashArrayParams = parameters; dashArrayParams.z = std::floor(dashArrayParams.z); diff --git a/src/mbgl/renderer/render_line_layer.hpp b/src/mbgl/renderer/render_line_layer.hpp index 0bde6f9a8..15052deb3 100644 --- a/src/mbgl/renderer/render_line_layer.hpp +++ b/src/mbgl/renderer/render_line_layer.hpp @@ -14,8 +14,8 @@ public: std::unique_ptr clone() const override; - void cascade(const style::CascadeParameters&) override; - bool evaluate(const style::PropertyEvaluationParameters&) override; + void cascade(const CascadeParameters&) override; + bool evaluate(const PropertyEvaluationParameters&) override; bool queryIntersectsFeature( const GeometryCoordinates&, diff --git a/src/mbgl/renderer/render_raster_layer.cpp b/src/mbgl/renderer/render_raster_layer.cpp index f877a0239..0cfccc81b 100644 --- a/src/mbgl/renderer/render_raster_layer.cpp +++ b/src/mbgl/renderer/render_raster_layer.cpp @@ -18,11 +18,11 @@ std::unique_ptr RenderRasterLayer::createBucket(const BucketParameters&, return nullptr; } -void RenderRasterLayer::cascade(const style::CascadeParameters& parameters) { +void RenderRasterLayer::cascade(const CascadeParameters& parameters) { unevaluated = impl->cascading.cascade(parameters, std::move(unevaluated)); } -bool RenderRasterLayer::evaluate(const style::PropertyEvaluationParameters& parameters) { +bool RenderRasterLayer::evaluate(const PropertyEvaluationParameters& parameters) { evaluated = unevaluated.evaluate(parameters); passes = evaluated.get() > 0 ? RenderPass::Translucent : RenderPass::None; diff --git a/src/mbgl/renderer/render_raster_layer.hpp b/src/mbgl/renderer/render_raster_layer.hpp index 1fd0fe7c4..c6e38fa14 100644 --- a/src/mbgl/renderer/render_raster_layer.hpp +++ b/src/mbgl/renderer/render_raster_layer.hpp @@ -14,8 +14,8 @@ public: std::unique_ptr clone() const override; - void cascade(const style::CascadeParameters&) override; - bool evaluate(const style::PropertyEvaluationParameters&) override; + void cascade(const CascadeParameters&) override; + bool evaluate(const PropertyEvaluationParameters&) override; std::unique_ptr createBucket(const BucketParameters&, const std::vector&) const override; diff --git a/src/mbgl/renderer/render_source.hpp b/src/mbgl/renderer/render_source.hpp index 5d93ae49d..bec1d24d0 100644 --- a/src/mbgl/renderer/render_source.hpp +++ b/src/mbgl/renderer/render_source.hpp @@ -21,15 +21,12 @@ class RenderedQueryOptions; class SourceQueryOptions; class Tile; class RenderSourceObserver; +class UpdateParameters; namespace algorithm { class ClipIDGenerator; } // namespace algorithm -namespace style { -class UpdateParameters; -} // namespace style - class RenderSource : protected TileObserver { public: RenderSource(const style::Source::Impl&); @@ -39,7 +36,7 @@ public: // Called when the camera has changed. May load new tiles, unload obsolete tiles, or // trigger re-placement of existing complete tiles. - virtual void updateTiles(const style::UpdateParameters&) = 0; + virtual void updateTiles(const UpdateParameters&) = 0; // Removes all tiles (by putting them into the cache). virtual void removeTiles() = 0; diff --git a/src/mbgl/renderer/render_symbol_layer.cpp b/src/mbgl/renderer/render_symbol_layer.cpp index d46dc614f..0c3601aed 100644 --- a/src/mbgl/renderer/render_symbol_layer.cpp +++ b/src/mbgl/renderer/render_symbol_layer.cpp @@ -2,8 +2,8 @@ #include #include #include +#include #include -#include #include namespace mbgl { @@ -34,11 +34,11 @@ std::unique_ptr RenderSymbolLayer::createLayout(const BucketParame glyphDependencies); } -void RenderSymbolLayer::cascade(const style::CascadeParameters& parameters) { +void RenderSymbolLayer::cascade(const CascadeParameters& parameters) { unevaluated = impl->cascading.cascade(parameters, std::move(unevaluated)); } -bool RenderSymbolLayer::evaluate(const style::PropertyEvaluationParameters& parameters) { +bool RenderSymbolLayer::evaluate(const PropertyEvaluationParameters& parameters) { evaluated = unevaluated.evaluate(parameters); auto hasIconOpacity = evaluated.get().constantOr(Color::black()).a > 0 || diff --git a/src/mbgl/renderer/render_symbol_layer.hpp b/src/mbgl/renderer/render_symbol_layer.hpp index b19b236e9..b9c2cc324 100644 --- a/src/mbgl/renderer/render_symbol_layer.hpp +++ b/src/mbgl/renderer/render_symbol_layer.hpp @@ -66,8 +66,8 @@ public: std::unique_ptr clone() const override; - void cascade(const style::CascadeParameters&) override; - bool evaluate(const style::PropertyEvaluationParameters&) override; + void cascade(const CascadeParameters&) override; + bool evaluate(const PropertyEvaluationParameters&) override; style::IconPaintProperties::Evaluated iconPaintProperties() const; style::TextPaintProperties::Evaluated textPaintProperties() const; diff --git a/src/mbgl/renderer/sources/render_geojson_source.hpp b/src/mbgl/renderer/sources/render_geojson_source.hpp index 3476b63af..502df0f1c 100644 --- a/src/mbgl/renderer/sources/render_geojson_source.hpp +++ b/src/mbgl/renderer/sources/render_geojson_source.hpp @@ -18,7 +18,7 @@ public: // Called when the camera has changed. May load new tiles, unload obsolete tiles, or // trigger re-placement of existing complete tiles. - void updateTiles(const style::UpdateParameters&) final; + void updateTiles(const UpdateParameters&) final; // Removes all tiles (by putting them into the cache). void removeTiles() final; diff --git a/src/mbgl/renderer/sources/render_raster_source.hpp b/src/mbgl/renderer/sources/render_raster_source.hpp index 6b95be363..ebb7b6215 100644 --- a/src/mbgl/renderer/sources/render_raster_source.hpp +++ b/src/mbgl/renderer/sources/render_raster_source.hpp @@ -14,7 +14,7 @@ public: // Called when the camera has changed. May load new tiles, unload obsolete tiles, or // trigger re-placement of existing complete tiles. - void updateTiles(const style::UpdateParameters&) final; + void updateTiles(const UpdateParameters&) final; // Removes all tiles (by putting them into the cache). void removeTiles() final; diff --git a/src/mbgl/renderer/sources/render_vector_source.hpp b/src/mbgl/renderer/sources/render_vector_source.hpp index 0f40c14cf..c435db6f0 100644 --- a/src/mbgl/renderer/sources/render_vector_source.hpp +++ b/src/mbgl/renderer/sources/render_vector_source.hpp @@ -14,7 +14,7 @@ public: // Called when the camera has changed. May load new tiles, unload obsolete tiles, or // trigger re-placement of existing complete tiles. - void updateTiles(const style::UpdateParameters&) final; + void updateTiles(const UpdateParameters&) final; // Removes all tiles (by putting them into the cache). void removeTiles() final; diff --git a/src/mbgl/renderer/tile_pyramid.cpp b/src/mbgl/renderer/tile_pyramid.cpp index 130b9dc5b..97f9f3193 100644 --- a/src/mbgl/renderer/tile_pyramid.cpp +++ b/src/mbgl/renderer/tile_pyramid.cpp @@ -2,7 +2,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/src/mbgl/renderer/tile_pyramid.hpp b/src/mbgl/renderer/tile_pyramid.hpp index a38a21dd8..b8ffbfb2b 100644 --- a/src/mbgl/renderer/tile_pyramid.hpp +++ b/src/mbgl/renderer/tile_pyramid.hpp @@ -22,10 +22,7 @@ class TransformState; class RenderTile; class RenderedQueryOptions; class SourceQueryOptions; - -namespace style { class UpdateParameters; -} // namespace style class TilePyramid { public: @@ -36,7 +33,7 @@ public: // Called when the camera has changed. May load new tiles, unload obsolete tiles, or // trigger re-placement of existing complete tiles. - void updateTiles(const style::UpdateParameters&, + void updateTiles(const UpdateParameters&, SourceType type, uint16_t tileSize, Range zoomRange, diff --git a/src/mbgl/style/transitioning_property.hpp b/src/mbgl/renderer/transitioning_property.hpp similarity index 96% rename from src/mbgl/style/transitioning_property.hpp rename to src/mbgl/renderer/transitioning_property.hpp index 5456322b3..c211ccf11 100644 --- a/src/mbgl/style/transitioning_property.hpp +++ b/src/mbgl/renderer/transitioning_property.hpp @@ -8,7 +8,6 @@ #include namespace mbgl { -namespace style { template class TransitioningProperty { @@ -17,7 +16,7 @@ public: TransitioningProperty(Value value_, TransitioningProperty prior_, - TransitionOptions transition, + style::TransitionOptions transition, TimePoint now) : begin(now + transition.delay.value_or(Duration::zero())), end(begin + transition.duration.value_or(Duration::zero())), @@ -73,5 +72,4 @@ private: Value value; }; -} // namespace style } // namespace mbgl diff --git a/src/mbgl/style/update_parameters.hpp b/src/mbgl/renderer/update_parameters.hpp similarity index 94% rename from src/mbgl/style/update_parameters.hpp rename to src/mbgl/renderer/update_parameters.hpp index 900f4b518..a00e01b97 100644 --- a/src/mbgl/style/update_parameters.hpp +++ b/src/mbgl/renderer/update_parameters.hpp @@ -10,8 +10,8 @@ class FileSource; class AnnotationManager; namespace style { - class Style; +} // namespace style class UpdateParameters { public: @@ -22,7 +22,7 @@ public: FileSource& fileSource_, const MapMode mode_, AnnotationManager& annotationManager_, - Style& style_) + style::Style& style_) : pixelRatio(pixelRatio_), debugOptions(debugOptions_), transformState(transformState_), @@ -41,8 +41,7 @@ public: AnnotationManager& annotationManager; // TODO: remove - Style& style; + style::Style& style; }; -} // namespace style } // namespace mbgl diff --git a/src/mbgl/style/layout_property.hpp b/src/mbgl/style/layout_property.hpp index e2137deb9..3b9d6114c 100644 --- a/src/mbgl/style/layout_property.hpp +++ b/src/mbgl/style/layout_property.hpp @@ -2,15 +2,16 @@ #include #include -#include -#include +#include +#include #include namespace mbgl { -namespace style { class PropertyEvaluationParameters; +namespace style { + template class LayoutProperty { public: diff --git a/src/mbgl/style/paint_property.hpp b/src/mbgl/style/paint_property.hpp index dd8d6c0b5..f1752e69d 100644 --- a/src/mbgl/style/paint_property.hpp +++ b/src/mbgl/style/paint_property.hpp @@ -1,16 +1,16 @@ #pragma once -#include #include #include #include -#include -#include -#include -#include #include -#include -#include +#include +#include +#include +#include +#include +#include +#include #include #include #include diff --git a/src/mbgl/style/style.cpp b/src/mbgl/style/style.cpp index 5fc9c40eb..23536e0e3 100644 --- a/src/mbgl/style/style.cpp +++ b/src/mbgl/style/style.cpp @@ -16,13 +16,13 @@ #include #include #include -#include -#include -#include #include #include #include #include +#include +#include +#include #include #include #include diff --git a/src/mbgl/style/style.hpp b/src/mbgl/style/style.hpp index 6c80a2ef5..fe588c3ce 100644 --- a/src/mbgl/style/style.hpp +++ b/src/mbgl/style/style.hpp @@ -7,7 +7,7 @@ #include #include #include -#include +#include #include #include #include @@ -36,11 +36,11 @@ class RenderedQueryOptions; class Scheduler; class RenderLayer; class RenderSource; +class UpdateParameters; namespace style { class Layer; -class UpdateParameters; class QueryParameters; class Style : public GlyphAtlasObserver, diff --git a/src/mbgl/tile/geojson_tile.cpp b/src/mbgl/tile/geojson_tile.cpp index 4e0623c18..21c29f3eb 100644 --- a/src/mbgl/tile/geojson_tile.cpp +++ b/src/mbgl/tile/geojson_tile.cpp @@ -2,7 +2,7 @@ #include #include #include -#include +#include #include #include @@ -84,7 +84,7 @@ public: GeoJSONTile::GeoJSONTile(const OverscaledTileID& overscaledTileID, std::string sourceID_, - const style::UpdateParameters& parameters, + const UpdateParameters& parameters, mapbox::geometry::feature_collection features) : GeometryTile(overscaledTileID, sourceID_, parameters, *parameters.style.glyphAtlas, diff --git a/src/mbgl/tile/geojson_tile.hpp b/src/mbgl/tile/geojson_tile.hpp index 0bafe14bd..8bb0cb01b 100644 --- a/src/mbgl/tile/geojson_tile.hpp +++ b/src/mbgl/tile/geojson_tile.hpp @@ -5,15 +5,13 @@ namespace mbgl { -namespace style { class UpdateParameters; -} // namespace style class GeoJSONTile : public GeometryTile { public: GeoJSONTile(const OverscaledTileID&, std::string sourceID, - const style::UpdateParameters&, + const UpdateParameters&, mapbox::geometry::feature_collection); void updateData(mapbox::geometry::feature_collection); diff --git a/src/mbgl/tile/geometry_tile.cpp b/src/mbgl/tile/geometry_tile.cpp index 6ac4a2e3a..e995347f7 100644 --- a/src/mbgl/tile/geometry_tile.cpp +++ b/src/mbgl/tile/geometry_tile.cpp @@ -2,10 +2,10 @@ #include #include #include -#include #include #include #include +#include #include #include #include @@ -28,7 +28,7 @@ using namespace style; GeometryTile::GeometryTile(const OverscaledTileID& id_, std::string sourceID_, - const style::UpdateParameters& parameters, + const UpdateParameters& parameters, GlyphAtlas& glyphAtlas_, SpriteAtlas& spriteAtlas_) : Tile(id_), diff --git a/src/mbgl/tile/geometry_tile.hpp b/src/mbgl/tile/geometry_tile.hpp index 227e774e9..c54e48a5b 100644 --- a/src/mbgl/tile/geometry_tile.hpp +++ b/src/mbgl/tile/geometry_tile.hpp @@ -20,17 +20,17 @@ class FeatureIndex; class CollisionTile; class RenderLayer; class SourceQueryOptions; +class UpdateParameters; namespace style { class Style; -class UpdateParameters; } // namespace style class GeometryTile : public Tile, public GlyphRequestor, IconRequestor { public: GeometryTile(const OverscaledTileID&, std::string sourceID, - const style::UpdateParameters&, + const UpdateParameters&, GlyphAtlas&, SpriteAtlas&); diff --git a/src/mbgl/tile/geometry_tile_worker.cpp b/src/mbgl/tile/geometry_tile_worker.cpp index 550e06bae..a2d1f1590 100644 --- a/src/mbgl/tile/geometry_tile_worker.cpp +++ b/src/mbgl/tile/geometry_tile_worker.cpp @@ -249,13 +249,13 @@ static std::vector> toRenderLayers(const std::vecto for (auto& layer : layers) { renderLayers.push_back(layer->baseImpl->createRenderLayer()); - renderLayers.back()->cascade(style::CascadeParameters { + renderLayers.back()->cascade(CascadeParameters { { ClassID::Default }, Clock::time_point::max(), TransitionOptions() }); - renderLayers.back()->evaluate(style::PropertyEvaluationParameters { + renderLayers.back()->evaluate(PropertyEvaluationParameters { zoom, Clock::time_point::max(), ZoomHistory(), diff --git a/src/mbgl/tile/raster_tile.cpp b/src/mbgl/tile/raster_tile.cpp index 65907eb92..d670a142f 100644 --- a/src/mbgl/tile/raster_tile.cpp +++ b/src/mbgl/tile/raster_tile.cpp @@ -3,17 +3,17 @@ #include #include #include -#include #include #include #include +#include #include #include namespace mbgl { RasterTile::RasterTile(const OverscaledTileID& id_, - const style::UpdateParameters& parameters, + const UpdateParameters& parameters, const Tileset& tileset) : Tile(id_), loader(*this, id_, parameters, tileset), diff --git a/src/mbgl/tile/raster_tile.hpp b/src/mbgl/tile/raster_tile.hpp index 47f67a084..c2ece70ab 100644 --- a/src/mbgl/tile/raster_tile.hpp +++ b/src/mbgl/tile/raster_tile.hpp @@ -8,16 +8,16 @@ namespace mbgl { class Tileset; +class UpdateParameters; namespace style { class Layer; -class UpdateParameters; } // namespace style class RasterTile : public Tile { public: RasterTile(const OverscaledTileID&, - const style::UpdateParameters&, + const UpdateParameters&, const Tileset&); ~RasterTile() final; diff --git a/src/mbgl/tile/tile_loader.hpp b/src/mbgl/tile/tile_loader.hpp index 0d64f647d..125f82f0f 100644 --- a/src/mbgl/tile/tile_loader.hpp +++ b/src/mbgl/tile/tile_loader.hpp @@ -10,17 +10,14 @@ class FileSource; class AsyncRequest; class Response; class Tileset; - -namespace style { class UpdateParameters; -} // namespace style template class TileLoader : private util::noncopyable { public: TileLoader(T&, const OverscaledTileID&, - const style::UpdateParameters&, + const UpdateParameters&, const Tileset&); ~TileLoader(); diff --git a/src/mbgl/tile/tile_loader_impl.hpp b/src/mbgl/tile/tile_loader_impl.hpp index 9a5b35a7a..7d7839f80 100644 --- a/src/mbgl/tile/tile_loader_impl.hpp +++ b/src/mbgl/tile/tile_loader_impl.hpp @@ -2,7 +2,7 @@ #include #include -#include +#include #include #include @@ -12,7 +12,7 @@ namespace mbgl { template TileLoader::TileLoader(T& tile_, const OverscaledTileID& id, - const style::UpdateParameters& parameters, + const UpdateParameters& parameters, const Tileset& tileset) : tile(tile_), necessity(Necessity::Optional), diff --git a/src/mbgl/tile/vector_tile.cpp b/src/mbgl/tile/vector_tile.cpp index 277a17667..d43ab7400 100644 --- a/src/mbgl/tile/vector_tile.cpp +++ b/src/mbgl/tile/vector_tile.cpp @@ -2,7 +2,7 @@ #include #include #include -#include +#include #include @@ -83,7 +83,7 @@ private: VectorTile::VectorTile(const OverscaledTileID& id_, std::string sourceID_, - const style::UpdateParameters& parameters, + const UpdateParameters& parameters, const Tileset& tileset) : GeometryTile(id_, sourceID_, parameters, *parameters.style.glyphAtlas, diff --git a/src/mbgl/tile/vector_tile.hpp b/src/mbgl/tile/vector_tile.hpp index 2568a277e..175b71c21 100644 --- a/src/mbgl/tile/vector_tile.hpp +++ b/src/mbgl/tile/vector_tile.hpp @@ -6,16 +6,13 @@ namespace mbgl { class Tileset; - -namespace style { class UpdateParameters; -} // namespace style class VectorTile : public GeometryTile { public: VectorTile(const OverscaledTileID&, std::string sourceID, - const style::UpdateParameters&, + const UpdateParameters&, const Tileset&); void setNecessity(Necessity) final; diff --git a/test/style/function/camera_function.test.cpp b/test/style/function/camera_function.test.cpp index 6cd53b0fa..59e3f2cef 100644 --- a/test/style/function/camera_function.test.cpp +++ b/test/style/function/camera_function.test.cpp @@ -1,8 +1,8 @@ #include #include -#include -#include +#include +#include using namespace mbgl; using namespace mbgl::style; diff --git a/test/style/paint_property.test.cpp b/test/style/paint_property.test.cpp index 15a0796f2..1854351f7 100644 --- a/test/style/paint_property.test.cpp +++ b/test/style/paint_property.test.cpp @@ -1,7 +1,7 @@ #include #include -#include +#include using namespace mbgl; using namespace mbgl::style; diff --git a/test/style/source.test.cpp b/test/style/source.test.cpp index 6a336a8c2..a651fd896 100644 --- a/test/style/source.test.cpp +++ b/test/style/source.test.cpp @@ -23,7 +23,7 @@ #include #include -#include +#include #include #include #include @@ -46,7 +46,7 @@ public: AnnotationManager annotationManager { 1.0 }; style::Style style { threadPool, fileSource, 1.0 }; - style::UpdateParameters updateParameters { + UpdateParameters updateParameters { 1.0, MapDebugOptions(), transformState, diff --git a/test/tile/annotation_tile.test.cpp b/test/tile/annotation_tile.test.cpp index 032f91806..64d2c8f1f 100644 --- a/test/tile/annotation_tile.test.cpp +++ b/test/tile/annotation_tile.test.cpp @@ -6,7 +6,7 @@ #include #include #include -#include +#include #include #include #include @@ -26,7 +26,7 @@ public: AnnotationManager annotationManager { 1.0 }; style::Style style { threadPool, fileSource, 1.0 }; - style::UpdateParameters updateParameters { + UpdateParameters updateParameters { 1.0, MapDebugOptions(), transformState, diff --git a/test/tile/geojson_tile.test.cpp b/test/tile/geojson_tile.test.cpp index f39ff0a4c..5d3a28c26 100644 --- a/test/tile/geojson_tile.test.cpp +++ b/test/tile/geojson_tile.test.cpp @@ -8,7 +8,7 @@ #include #include #include -#include +#include #include #include @@ -27,7 +27,7 @@ public: style::Style style { threadPool, fileSource, 1.0 }; Tileset tileset { { "https://example.com" }, { 0, 22 }, "none" }; - style::UpdateParameters updateParameters { + UpdateParameters updateParameters { 1.0, MapDebugOptions(), transformState, diff --git a/test/tile/raster_tile.test.cpp b/test/tile/raster_tile.test.cpp index 1d1e7d746..5543c3c56 100644 --- a/test/tile/raster_tile.test.cpp +++ b/test/tile/raster_tile.test.cpp @@ -7,8 +7,8 @@ #include #include #include -#include #include +#include #include using namespace mbgl; @@ -23,7 +23,7 @@ public: style::Style style { threadPool, fileSource, 1.0 }; Tileset tileset { { "https://example.com" }, { 0, 22 }, "none" }; - style::UpdateParameters updateParameters { + UpdateParameters updateParameters { 1.0, MapDebugOptions(), transformState, diff --git a/test/tile/vector_tile.test.cpp b/test/tile/vector_tile.test.cpp index 15d437c36..244892f22 100644 --- a/test/tile/vector_tile.test.cpp +++ b/test/tile/vector_tile.test.cpp @@ -8,8 +8,8 @@ #include #include #include -#include #include +#include #include #include #include @@ -29,7 +29,7 @@ public: style::Style style { threadPool, fileSource, 1.0 }; Tileset tileset { { "https://example.com" }, { 0, 22 }, "none" }; - style::UpdateParameters updateParameters { + UpdateParameters updateParameters { 1.0, MapDebugOptions(), transformState,