tei/MapLibreParticleLab
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[core, tests] Don't break text-field support "identity functions"

Browse Source
This commit is contained in:
Chris Loer
2018-10-01 14:06:49 -07:00
committed by Chris Loer
parent fdfb9386a6
commit d4c9b21bae
2 changed files with 21 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
test/style/conversion/function.test.cpp
View File

@@ -92,3 +92,21 @@ TEST(StyleConversion, TokenStrings) {
ASSERT_EQ(*convertTokenStringToExpression("{token} {token"), *concat(vec(get(literal("token")), literal(" "), literal("{token"))));
ASSERT_EQ(*convertTokenStringToExpression("{token {token}"), *concat(vec(literal("{token "), get(literal("token")))));
}
TEST(StyleConversion, FormattedIdentityFunction) {
// See https://github.com/mapbox/mapbox-gl-js/issues/7311
// We never introduced this bug on gl-native, but we _almost_ did
Error error;
auto parseFunction = [&](const std::string& json) {
return convertJSON<PropertyValue<mbgl::style::expression::Formatted>>(json, error, true, false);
};
using namespace mbgl::style::expression::dsl;
auto fn1 = parseFunction(R"({ "property": "name", "type": "identity" })");
ASSERT_TRUE(bool(fn1));
ASSERT_TRUE(fn1->isExpression());
ASSERT_EQ(fn1->asExpression().getExpression(), *format(get(literal("name"))));
}