tei/MapLibreParticleLab
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace M_PI with std::numbers:pi (#2713)

Browse Source
This commit is contained in:
Bart Louwers
2024-08-13 01:26:49 +02:00
committed by GitHub
parent b42fa344b3
commit d19ab42d0a
22 changed files with 126 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
test/util/camera.test.cpp
View File

@@ -7,7 +7,10 @@
#include <gmock/gmock.h>
#include <numbers>
using namespace mbgl;
using namespace std::numbers;
static const double abs_double_error = 1e-7;
@@ -19,7 +22,7 @@ MATCHER_P(Vec3NearEquals1E7, vec, "") {
TEST(FreeCameraOptions, SetLocation) {
FreeCameraOptions options;
options.setLocation({{0.0, 0.0}, util::EARTH_RADIUS_M * M_PI});
options.setLocation({{0.0, 0.0}, util::EARTH_RADIUS_M * pi});
ASSERT_TRUE(options.position);
ASSERT_THAT(options.position.value(), Vec3NearEquals1E7(vec3{{0.5, 0.5, 0.5}}));
@@ -28,12 +31,12 @@ TEST(FreeCameraOptions, SetLocation) {
ASSERT_THAT(options.position.value(), Vec3NearEquals1E7(vec3{{0.0, 0.4282409625, 0.000027532812465}}));
options.setLocation(
{{util::LATITUDE_MAX, 0.0}, util::EARTH_RADIUS_M * M_PI * std::cos(util::deg2rad(util::LATITUDE_MAX))});
{{util::LATITUDE_MAX, 0.0}, util::EARTH_RADIUS_M * pi * std::cos(util::deg2rad(util::LATITUDE_MAX))});
ASSERT_TRUE(options.position);
ASSERT_THAT(options.position.value(), Vec3NearEquals1E7(vec3{{0.5, 0.0, 0.5}}));
options.setLocation(
{{-util::LATITUDE_MAX, 0.0}, util::EARTH_RADIUS_M * M_PI * std::cos(util::deg2rad(-util::LATITUDE_MAX))});
{{-util::LATITUDE_MAX, 0.0}, util::EARTH_RADIUS_M * pi * std::cos(util::deg2rad(-util::LATITUDE_MAX))});
ASSERT_TRUE(options.position);
ASSERT_THAT(options.position.value(), Vec3NearEquals1E7(vec3{{0.5, 1.0, 0.5}}));
}
@@ -97,7 +100,7 @@ TEST(FreeCameraOptions, GetLocationNegativeAltitude) {
const auto latLngAltitude = options.getLocation();
ASSERT_TRUE(latLngAltitude);
ASSERT_DOUBLE_EQ(latLngAltitude->altitude, -0.5 * util::EARTH_RADIUS_M * M_PI);
ASSERT_DOUBLE_EQ(latLngAltitude->altitude, -0.5 * util::EARTH_RADIUS_M * pi);
}
TEST(FreeCameraOptions, GetLocationUnwrappedPosition) {