diff --git a/render-test/parser.cpp b/render-test/parser.cpp index 88c5f5cac..7646b5b45 100644 --- a/render-test/parser.cpp +++ b/render-test/parser.cpp @@ -1294,7 +1294,8 @@ std::string createResultItem(const TestMetadata& metadata, bool hasFailedTests) std::string html; html.append("
\n"); html.append(R"(

" + metadata.status + " " + metadata.id + "

\n"); - if (metadata.status != "errored") { + + if (!metadata.renderErrored) { if (metadata.outputsImage) { if (metadata.renderTest) { html.append("\n"); } } - - if (metadata.metricsFailed) { - html.append("

Error: " + metadata.errorMessage + "

\n"); - } } else { // FIXME: there are several places that errorMessage is not filled // comment out assert(!metadata.errorMessage.empty()); html.append("

Error: " + metadata.errorMessage + "

\n"); } + + if (metadata.metricsFailed || metadata.metricsErrored) { + html.append("

Error: " + metadata.errorMessage + "

\n"); + } + if (metadata.difference != 0.0) { if (metadata.renderTest) { html.append("

Diff: " + mbgl::util::toString(metadata.difference) +