Apply just the changes from the MLT branch which aren't really part of that work (#3793)

include/mbgl/gfx/polyline_generator.hpp

@@ -10,7 +10,6 @@
 
 #include <cstdint>
 #include <cstddef>
-#include <memory>
 #include <vector>
 #include <functional>
 #include <optional>

include/mbgl/gl/uniform_buffer_gl.hpp

@@ -31,7 +31,7 @@ private:
 
     // unique id used for debugging and profiling purposes
     // localID should not be used as unique id because a const buffer pool is managed using IBufferAllocator
-// Currently unique IDs for constant buffers are only used when Tracy profiling is enabled
+    // Currently unique IDs for constant buffers are only used when Tracy profiling is enabled
 #ifdef MLN_TRACY_ENABLE
     int64_t uniqueDebugId = -1;
 #endif

include/mbgl/style/expression/format_section_override.hpp

@@ -21,8 +21,8 @@ public:
         using Object = std::unordered_map<std::string, expression::Value>;
         if (context.formattedSection && context.formattedSection->is<Object>()) {
             const auto& section = context.formattedSection->get<Object>();
-            if (section.find(propertyName) != section.end()) {
-                return section.at(propertyName);
+            if (auto hit = section.find(propertyName); hit != section.end()) {
+                return hit->second;
             }
         }
 

include/mbgl/util/bitmask_operations.hpp

@@ -8,6 +8,7 @@ namespace mbgl {
 template <typename Enum>
 constexpr Enum operator|(Enum a, Enum b) {
     static_assert(std::is_enum_v<Enum>, "Enum must be an enum type");
+    // NOLINTNEXTLINE(clang-analyzer-optin.core.EnumCastOutOfRange)
     return Enum(mbgl::underlying_type(a) | mbgl::underlying_type(b));
 }
 

include/mbgl/util/compression.hpp

@@ -13,6 +13,7 @@ enum CompressionFormat {
     DETECT = 15 + 32
 };
 
+bool is_compressed(const std::string&);
 std::string compress(const std::string& raw, int windowBits = CompressionFormat::ZLIB);
 std::string decompress(const std::string& raw, int windowBits = CompressionFormat::DETECT);
 

include/mbgl/util/work_task_impl.hpp

@@ -1,7 +1,6 @@
 #pragma once
 
 #include <mbgl/util/work_task.hpp>
-#include <mbgl/util/run_loop.hpp>
 
 #include <mutex>