From bbccce18c4d064054726f66e0b9b41cebfe314e4 Mon Sep 17 00:00:00 2001 From: John Firebaugh Date: Fri, 20 Jul 2018 13:32:05 -0700 Subject: [PATCH] [build] Disable binary size checks for fork PRs We can't run the checks without potentially exposing the Github App private key to malicious PRs. --- scripts/check_binary_size.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/scripts/check_binary_size.js b/scripts/check_binary_size.js index a12939c2a..9caa1b999 100755 --- a/scripts/check_binary_size.js +++ b/scripts/check_binary_size.js @@ -18,7 +18,13 @@ process.on('unhandledRejection', error => { process.exit(1) }); -const key = Buffer.from(process.env['SIZE_CHECK_APP_PRIVATE_KEY'], 'base64').toString('binary'); +const pk = process.env['SIZE_CHECK_APP_PRIVATE_KEY']; +if (!pk) { + console.log('Fork PR; not computing size.'); + process.exit(0); +} + +const key = Buffer.from(pk, 'base64').toString('binary'); const payload = { exp: Math.floor(Date.now() / 1000) + 60, iat: Math.floor(Date.now() / 1000),