[core] Fix performance-unnecessary-value-param errors in header files
As reported by clang-tidy-8.
This commit is contained in:
@@ -39,8 +39,8 @@ public:
|
||||
delegate.invoke(&RendererObserver::onDidFinishRenderingFrame, mode, repaintNeeded, placementChanged);
|
||||
}
|
||||
|
||||
void onStyleImageMissing(const std::string& image, StyleImageMissingCallback cb) override {
|
||||
delegate.invoke(&RendererObserver::onStyleImageMissing, image, std::move(cb));
|
||||
void onStyleImageMissing(const std::string& image, const StyleImageMissingCallback& cb) override {
|
||||
delegate.invoke(&RendererObserver::onStyleImageMissing, image, cb);
|
||||
}
|
||||
|
||||
private:
|
||||
@@ -76,7 +76,7 @@ public:
|
||||
rendererObserver->onDidFinishRenderingFrame(mode, repaintNeeded, placementChanged);
|
||||
}
|
||||
|
||||
void onStyleImageMissing(const std::string& id, StyleImageMissingCallback done) override {
|
||||
void onStyleImageMissing(const std::string& id, const StyleImageMissingCallback& done) override {
|
||||
rendererObserver->onStyleImageMissing(id, done);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user