From acbcf7e7e6b1575c1461354c807d4ca3ebfc7fb8 Mon Sep 17 00:00:00 2001 From: Jason Wray Date: Thu, 28 Jun 2018 17:18:51 -0400 Subject: [PATCH] [ios] Preserve bcsymbolmap files when using CocoaPods Bitcode symbol map files (`bcsymbolmap`) are used in conjunction with dSYMs to symbolicate crashes. CocoaPods doesn't yet preserve these or add them to an app's `xcarchive`, so the developer needs to do this themselves (typically as an install-only build copy phase). --- platform/ios/CHANGELOG.md | 4 ++++ platform/ios/Mapbox-iOS-SDK-nightly-dynamic.podspec | 2 ++ platform/ios/Mapbox-iOS-SDK-symbols.podspec | 2 ++ platform/ios/Mapbox-iOS-SDK.podspec | 2 ++ 4 files changed, 10 insertions(+) diff --git a/platform/ios/CHANGELOG.md b/platform/ios/CHANGELOG.md index d3deed254..c49dc4381 100644 --- a/platform/ios/CHANGELOG.md +++ b/platform/ios/CHANGELOG.md @@ -4,6 +4,10 @@ Mapbox welcomes participation and contributions from everyone. Please read [CONT ## 4.2.0 +### Packaging + +* When integrating this framework using CocoaPods, the included bcsymbolmap files are now preserved. If you have bitcode enabled and you are seeing incorrectly symbolicated crash logs, you should create a build phase in your Xcode project that copies these bcsymbolmap files to your app’s Products Directory when installing. ([#12257](https://github.com/mapbox/mapbox-gl-native/pull/12257)) + ### Styles and rendering * Added an `MGLRasterStyleLayer.rasterResamplingMode` property for configuring how raster style layers are overscaled. ([#12176](https://github.com/mapbox/mapbox-gl-native/pull/12176)) diff --git a/platform/ios/Mapbox-iOS-SDK-nightly-dynamic.podspec b/platform/ios/Mapbox-iOS-SDK-nightly-dynamic.podspec index 6364478f0..4b7d01550 100644 --- a/platform/ios/Mapbox-iOS-SDK-nightly-dynamic.podspec +++ b/platform/ios/Mapbox-iOS-SDK-nightly-dynamic.podspec @@ -27,4 +27,6 @@ Pod::Spec.new do |m| m.vendored_frameworks = 'dynamic/Mapbox.framework' m.module_name = 'Mapbox' + m.preserve_path = '**/*.bcsymbolmap' + end diff --git a/platform/ios/Mapbox-iOS-SDK-symbols.podspec b/platform/ios/Mapbox-iOS-SDK-symbols.podspec index c7f5d0f38..69d3b9ad0 100644 --- a/platform/ios/Mapbox-iOS-SDK-symbols.podspec +++ b/platform/ios/Mapbox-iOS-SDK-symbols.podspec @@ -27,4 +27,6 @@ Pod::Spec.new do |m| m.vendored_frameworks = 'dynamic/Mapbox.framework' m.module_name = 'Mapbox' + m.preserve_path = '**/*.bcsymbolmap' + end diff --git a/platform/ios/Mapbox-iOS-SDK.podspec b/platform/ios/Mapbox-iOS-SDK.podspec index bb4d2b2dc..6463ce815 100644 --- a/platform/ios/Mapbox-iOS-SDK.podspec +++ b/platform/ios/Mapbox-iOS-SDK.podspec @@ -27,4 +27,6 @@ Pod::Spec.new do |m| m.vendored_frameworks = 'dynamic/Mapbox.framework' m.module_name = 'Mapbox' + m.preserve_path = '**/*.bcsymbolmap' + end