From c1f425731cce475df42ab1050aec804efd1ffaec Mon Sep 17 00:00:00 2001 From: Maciej Swic Date: Mon, 21 Sep 2015 10:53:51 +0200 Subject: [PATCH 1/3] Fixed incorrect notification --- platform/ios/MGLMapView.mm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platform/ios/MGLMapView.mm b/platform/ios/MGLMapView.mm index 705627663..0febabc04 100644 --- a/platform/ios/MGLMapView.mm +++ b/platform/ios/MGLMapView.mm @@ -884,7 +884,7 @@ std::chrono::steady_clock::duration secondsAsDuration(float duration) self.centerPoint = CGPointMake(self.centerPoint.x + delta.x, self.centerPoint.y + delta.y); - [self notifyMapChange:mbgl::MapChangeRegionDidChangeAnimated]; + [self notifyMapChange:mbgl::MapChangeRegionIsChanging]; } else if (pan.state == UIGestureRecognizerStateEnded || pan.state == UIGestureRecognizerStateCancelled) { From ffb2ccde1cd0ce0464c49bee6fcd994f37a99a48 Mon Sep 17 00:00:00 2001 From: Maciej Swic Date: Mon, 21 Sep 2015 13:14:35 +0200 Subject: [PATCH 2/3] Notify map change on pinch as well --- platform/ios/MGLMapView.mm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/platform/ios/MGLMapView.mm b/platform/ios/MGLMapView.mm index 0febabc04..3033f02d6 100644 --- a/platform/ios/MGLMapView.mm +++ b/platform/ios/MGLMapView.mm @@ -960,6 +960,8 @@ std::chrono::steady_clock::duration secondsAsDuration(float duration) if (log2(newScale) < _mbglMap->getMinZoom()) return; _mbglMap->setScale(newScale, [pinch locationInView:pinch.view].x, [pinch locationInView:pinch.view].y); + + [self notifyMapChange:mbgl::MapChangeRegionIsChanging]; } else if (pinch.state == UIGestureRecognizerStateEnded || pinch.state == UIGestureRecognizerStateCancelled) { From aa30c20d884e9914d58bdf973b8739341ed8c128 Mon Sep 17 00:00:00 2001 From: Maciej Swic Date: Tue, 22 Sep 2015 08:44:24 +0200 Subject: [PATCH 3/3] Added region change notification to quick zoom --- platform/ios/MGLMapView.mm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/platform/ios/MGLMapView.mm b/platform/ios/MGLMapView.mm index 3033f02d6..bff2a1a0b 100644 --- a/platform/ios/MGLMapView.mm +++ b/platform/ios/MGLMapView.mm @@ -1335,6 +1335,8 @@ std::chrono::steady_clock::duration secondsAsDuration(float duration) if (newZoom < _mbglMap->getMinZoom()) return; _mbglMap->scaleBy(powf(2, newZoom) / _mbglMap->getScale(), self.bounds.size.width / 2, self.bounds.size.height / 2); + + [self notifyMapChange:mbgl::MapChangeRegionIsChanging]; } else if (quickZoom.state == UIGestureRecognizerStateEnded || quickZoom.state == UIGestureRecognizerStateCancelled) {