[core] Remove MapData::defaultTransitionDelay

include/mbgl/map/map.hpp

@@ -76,9 +76,6 @@ public:
     void setDefaultTransitionDuration(const Duration&);
     Duration getDefaultTransitionDuration() const;
 
-    void setDefaultTransitionDelay(const Duration&);
-    Duration getDefaultTransitionDelay() const;
-
     void setStyleURL(const std::string& url);
     void setStyleJSON(const std::string& json, const std::string& base = "");
     std::string getStyleURL() const;

src/mbgl/map/map.cpp

@@ -557,15 +557,6 @@ Duration Map::getDefaultTransitionDuration() const {
     return data->getDefaultTransitionDuration();
 }
 
-void Map::setDefaultTransitionDelay(const Duration& delay) {
-    data->setDefaultTransitionDelay(delay);
-    update(Update::DefaultTransition);
-}
-
-Duration Map::getDefaultTransitionDelay() const {
-    return data->getDefaultTransitionDelay();
-}
-
 void Map::setSourceTileCacheSize(size_t size) {
     context->invoke(&MapContext::setSourceTileCacheSize, size);
 }

src/mbgl/map/map_data.hpp

@@ -26,8 +26,7 @@ public:
         , annotationManager(pixelRatio)
         , animationTime(Duration::zero())
         , defaultFadeDuration(mode_ == MapMode::Continuous ? Milliseconds(300) : Duration::zero())
-        , defaultTransitionDuration(Duration::zero())
+        , defaultTransitionDuration(Duration::zero()) {
-        , defaultTransitionDelay(Duration::zero()) {
         assert(pixelRatio > 0);
     }
 
@@ -90,18 +89,6 @@ public:
         defaultTransitionDuration = duration;
     }
 
-    inline Duration getDefaultTransitionDelay() const {
-        return defaultTransitionDelay;
-    }
-
-    inline void setDefaultTransitionDelay(const Duration& delay) {
-        if (mode == MapMode::Still) {
-            return;
-        }
-
-        defaultTransitionDelay = delay;
-    }
-
     util::exclusive<AnnotationManager> getAnnotationManager() {
         return util::exclusive<AnnotationManager>(
             &annotationManager,
@@ -121,7 +108,6 @@ private:
     std::atomic<Duration> animationTime;
     std::atomic<Duration> defaultFadeDuration;
     std::atomic<Duration> defaultTransitionDuration;
-    std::atomic<Duration> defaultTransitionDelay;
 
 // TODO: make private
 public:

src/mbgl/style/paint_property.hpp

@@ -65,8 +65,8 @@ public:
     }
 
     void cascade(const StyleCascadeParameters& parameters) {
-        Duration delay = *parameters.defaultTransition.delay;
+        Duration delay = *parameters.userDefinedTransition.delay;
-        Duration duration = *parameters.defaultTransition.duration;
+        Duration duration = *parameters.userDefinedTransition.duration;
 
         for (auto classID : parameters.classes) {
             if (values.find(classID) == values.end())

src/mbgl/style/style.cpp

@@ -180,10 +180,11 @@ void Style::cascade() {
     classIDs.push_back(ClassID::Default);
     classIDs.push_back(ClassID::Fallback);
 
-    StyleCascadeParameters parameters(classIDs,
+    const StyleCascadeParameters parameters {
-                                      data.getAnimationTime(),
+        classIDs,
-                                      PropertyTransition { data.getDefaultTransitionDuration(),
+        data.getAnimationTime(),
-                                                           data.getDefaultTransitionDelay() });
+        PropertyTransition { data.getDefaultTransitionDuration(), Duration::zero() }
+    };
 
     for (const auto& layer : layers) {
         layer->cascade(parameters);

src/mbgl/style/style_cascade_parameters.hpp

@@ -12,16 +12,9 @@ class PropertyTransition;
 
 class StyleCascadeParameters {
 public:
-    StyleCascadeParameters(const std::vector<ClassID>& classes_,
-                           const TimePoint& now_,
-                           const PropertyTransition& defaultTransition_)
-        : classes(classes_),
-          now(now_),
-          defaultTransition(defaultTransition_) {}
-
     std::vector<ClassID> classes;
     TimePoint now;
-    PropertyTransition defaultTransition;
+    PropertyTransition userDefinedTransition;
 };
 
 } // namespace mbgl