From 9214584efb1b2777fb9d90885bde78173367113e Mon Sep 17 00:00:00 2001 From: Mike Morris Date: Wed, 27 May 2015 13:25:57 -0400 Subject: [PATCH] drop extraneous NodeFileSource v8::Persistent Remove from NodeRequest to stop preventing garbage collection. --- src/node_request.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/node_request.cpp b/src/node_request.cpp index 0fdc05bff..ccac813d2 100644 --- a/src/node_request.cpp +++ b/src/node_request.cpp @@ -35,11 +35,8 @@ NAN_METHOD(NodeRequest::New) { return NanThrowTypeError("Cannot create Request objects explicitly"); } - v8::Persistent source; - NanAssignPersistent(source, args[0]->ToObject()); - auto request = reinterpret_cast(args[1].As()->Value()); - auto req = new NodeRequest(NanNew(std::move(source)), request); + auto req = new NodeRequest(args[0]->ToObject(), request); req->Wrap(args.This()); NanReturnValue(args.This());