From 86691a08de77a5cfee2ba715b0b5cd138fbf9de4 Mon Sep 17 00:00:00 2001 From: Mike Morris Date: Wed, 3 Feb 2016 15:44:47 -0500 Subject: [PATCH] [node] patch memory leak in NodeMap::request Creating a v8::Function with Nan::GetFunction(Nan::New) can leak, use Nan::New instead. https://code.google.com/p/chromium/issues/detail?id=272579 --- platform/node/src/node_map.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platform/node/src/node_map.cpp b/platform/node/src/node_map.cpp index f5ebae110..b8927ea33 100644 --- a/platform/node/src/node_map.cpp +++ b/platform/node/src/node_map.cpp @@ -462,7 +462,7 @@ std::unique_ptr NodeMap::request(const mbgl::Resource& resour Nan::HandleScope scope; auto requestHandle = NodeRequest::Create(res, cb2)->ToObject(); - auto callbackHandle = Nan::GetFunction(Nan::New(NodeRequest::Respond, requestHandle)).ToLocalChecked(); + auto callbackHandle = Nan::New(NodeRequest::Respond, requestHandle); v8::Local argv[] = { requestHandle, callbackHandle }; Nan::MakeCallback(handle()->GetInternalField(1)->ToObject(), "request", 2, argv);