tei/MapLibreParticleLab
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[all] Do not set Response data for 404s

Browse Source 
For AssetFileSource and the node FileSource this was already the case; this makes the other implementations consistent.
This commit is contained in:
John Firebaugh
2016-02-03 17:35:06 -08:00
parent cdedb66387
commit 7eb1a91c4e
6 changed files with 15 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
platform/android/src/http_request_android.cpp
View File

@@ -199,17 +199,14 @@ void HTTPAndroidRequest::onResponse(JNIEnv* env, int code, jstring /* message */
response->expires = util::parseTimePoint(mbgl::android::std_string_from_jstring(env, expires).c_str());
}
if (body != nullptr) {
jbyte* bodyData = env->GetByteArrayElements(body, nullptr);
response->data = std::make_shared<std::string>(reinterpret_cast<char*>(bodyData), env->GetArrayLength(body));
env->ReleaseByteArrayElements(body, bodyData, JNI_ABORT);
}
if (code == 200) {
// Nothing to do; this is what we want
if (body != nullptr) {
jbyte* bodyData = env->GetByteArrayElements(body, nullptr);
response->data = std::make_shared<std::string>(reinterpret_cast<char*>(bodyData), env->GetArrayLength(body));
env->ReleaseByteArrayElements(body, bodyData, JNI_ABORT);
}
} else if (code == 304) {
response->notModified = true;
response->data.reset();
} else if (code == 404) {
response->error = std::make_unique<Error>(Error::Reason::NotFound, "HTTP status code 404");
} else if (code >= 500 && code < 600) {