diff --git a/src/mbgl/annotation/shape_annotation_impl.cpp b/src/mbgl/annotation/shape_annotation_impl.cpp index 3486c43d0..5d5f4e859 100644 --- a/src/mbgl/annotation/shape_annotation_impl.cpp +++ b/src/mbgl/annotation/shape_annotation_impl.cpp @@ -26,11 +26,13 @@ void ShapeAnnotationImpl::updateStyle(Style& style) { if (style.getLayer(layerID)) return; - std::unique_ptr layer; - std::string beforeLayerID = AnnotationManager::PointLayerID; - if (shape.properties.is()) { - layer = createLineLayer(); + type = ProjectedFeatureType::LineString; + + std::unique_ptr layer = std::make_unique(); + layer->type = StyleLayerType::Line; + + layer->layout.set(PropertyKey::LineJoin, Function(JoinType::Round)); const LinePaintProperties& properties = shape.properties.get(); ClassProperties paintProperties; @@ -39,8 +41,17 @@ void ShapeAnnotationImpl::updateStyle(Style& style) { paintProperties.set(PropertyKey::LineColor, Function(properties.color)); layer->paints.paints.emplace(ClassID::Default, std::move(paintProperties)); + layer->id = layerID; + layer->source = AnnotationManager::SourceID; + layer->sourceLayer = layer->id; + + style.addLayer(std::move(layer), AnnotationManager::PointLayerID); + } else if (shape.properties.is()) { - layer = createFillLayer(); + type = ProjectedFeatureType::Polygon; + + std::unique_ptr layer = std::make_unique(); + layer->type = StyleLayerType::Fill; const FillPaintProperties& properties = shape.properties.get(); ClassProperties paintProperties; @@ -49,49 +60,28 @@ void ShapeAnnotationImpl::updateStyle(Style& style) { paintProperties.set(PropertyKey::FillOutlineColor, Function(properties.stroke_color)); layer->paints.paints.emplace(ClassID::Default, std::move(paintProperties)); - } else { - beforeLayerID = shape.properties.get(); + layer->id = layerID; + layer->source = AnnotationManager::SourceID; + layer->sourceLayer = layer->id; - const StyleLayer* sourceLayer = style.getLayer(beforeLayerID); + style.addLayer(std::move(layer), AnnotationManager::PointLayerID); + + } else { + const StyleLayer* sourceLayer = style.getLayer(shape.properties.get()); if (!sourceLayer) return; - switch (sourceLayer->type) { - case StyleLayerType::Line: - layer = createLineLayer(); - break; + std::unique_ptr layer = sourceLayer->clone(); - case StyleLayerType::Fill: - layer = createFillLayer(); - break; + type = layer->type == StyleLayerType::Line + ? ProjectedFeatureType::LineString + : ProjectedFeatureType::Polygon; - default: - return; - } + layer->id = layerID; + layer->source = AnnotationManager::SourceID; + layer->sourceLayer = layer->id; - layer->paints.paints = sourceLayer->paints.paints; - layer->layout = sourceLayer->layout; + style.addLayer(std::move(layer), sourceLayer->id); } - - layer->id = layerID; - layer->source = AnnotationManager::SourceID; - layer->sourceLayer = layer->id; - - style.addLayer(std::move(layer), beforeLayerID); -} - -std::unique_ptr ShapeAnnotationImpl::createLineLayer() { - type = ProjectedFeatureType::LineString; - std::unique_ptr layer = std::make_unique(); - layer->type = StyleLayerType::Line; - layer->layout.set(PropertyKey::LineJoin, Function(JoinType::Round)); - return std::move(layer); -} - -std::unique_ptr ShapeAnnotationImpl::createFillLayer() { - type = ProjectedFeatureType::Polygon; - std::unique_ptr layer = std::make_unique(); - layer->type = StyleLayerType::Fill; - return std::move(layer); } void ShapeAnnotationImpl::updateTile(const TileID& tileID, AnnotationTile& tile) { diff --git a/src/mbgl/annotation/shape_annotation_impl.hpp b/src/mbgl/annotation/shape_annotation_impl.hpp index 8c703f664..f312ec75d 100644 --- a/src/mbgl/annotation/shape_annotation_impl.hpp +++ b/src/mbgl/annotation/shape_annotation_impl.hpp @@ -14,7 +14,6 @@ namespace mbgl { class Style; -class StyleLayer; class AnnotationTile; class ShapeAnnotationImpl { @@ -32,9 +31,6 @@ public: const ShapeAnnotation shape; private: - std::unique_ptr createLineLayer(); - std::unique_ptr createFillLayer(); - const uint8_t maxZoom; mapbox::util::geojsonvt::ProjectedFeatureType type; std::unique_ptr shapeTiler; diff --git a/src/mbgl/layer/background_layer.cpp b/src/mbgl/layer/background_layer.cpp index d7986d757..67e39a689 100644 --- a/src/mbgl/layer/background_layer.cpp +++ b/src/mbgl/layer/background_layer.cpp @@ -1,8 +1,17 @@ #include #include +#include namespace mbgl { +std::unique_ptr BackgroundLayer::clone() const { + std::unique_ptr result = std::make_unique(); + result->copy(*this); + result->layout = layout; + result->paints.paints = paints.paints; + return std::move(result); +} + void BackgroundLayer::parsePaints(const JSVal& layer) { paints.parseEach(layer, [&] (ClassProperties& paint, const JSVal& value) { parseProperty>("background-opacity", PropertyKey::BackgroundOpacity, paint, value); @@ -11,6 +20,14 @@ void BackgroundLayer::parsePaints(const JSVal& layer) { }); } +void BackgroundLayer::cascade(const StyleCascadeParameters& parameters) { + paints.cascade(parameters); +} + +bool BackgroundLayer::hasTransitions() const { + return paints.hasTransitions(); +} + void BackgroundLayer::recalculate(const StyleCalculationParameters& parameters) { paints.removeExpiredTransitions(parameters.now); diff --git a/src/mbgl/layer/background_layer.hpp b/src/mbgl/layer/background_layer.hpp index b333cd463..5a8b3496e 100644 --- a/src/mbgl/layer/background_layer.hpp +++ b/src/mbgl/layer/background_layer.hpp @@ -10,13 +10,21 @@ namespace mbgl { class BackgroundLayer : public StyleLayer { public: + std::unique_ptr clone() const override; + void parseLayout(const JSVal&) override {}; void parsePaints(const JSVal&) override; + void cascade(const StyleCascadeParameters&) override; void recalculate(const StyleCalculationParameters&) override; std::unique_ptr createBucket(StyleBucketParameters&) const override; + bool hasTransitions() const override; + + ClassProperties layout; + PaintPropertiesMap paints; + BackgroundPaintProperties properties; }; diff --git a/src/mbgl/layer/circle_layer.cpp b/src/mbgl/layer/circle_layer.cpp index e74e87ea9..c36d21c08 100644 --- a/src/mbgl/layer/circle_layer.cpp +++ b/src/mbgl/layer/circle_layer.cpp @@ -5,6 +5,14 @@ namespace mbgl { +std::unique_ptr CircleLayer::clone() const { + std::unique_ptr result = std::make_unique(); + result->copy(*this); + result->layout = layout; + result->paints.paints = paints.paints; + return std::move(result); +} + void CircleLayer::parsePaints(const JSVal& layer) { paints.parseEach(layer, [&] (ClassProperties& paint, const JSVal& value) { parseProperty>("circle-radius", PropertyKey::CircleRadius, paint, value); @@ -16,6 +24,14 @@ void CircleLayer::parsePaints(const JSVal& layer) { }); } +void CircleLayer::cascade(const StyleCascadeParameters& parameters) { + paints.cascade(parameters); +} + +bool CircleLayer::hasTransitions() const { + return paints.hasTransitions(); +} + void CircleLayer::recalculate(const StyleCalculationParameters& parameters) { paints.removeExpiredTransitions(parameters.now); diff --git a/src/mbgl/layer/circle_layer.hpp b/src/mbgl/layer/circle_layer.hpp index f07d30484..28943bff6 100644 --- a/src/mbgl/layer/circle_layer.hpp +++ b/src/mbgl/layer/circle_layer.hpp @@ -10,13 +10,21 @@ namespace mbgl { class CircleLayer : public StyleLayer { public: + std::unique_ptr clone() const override; + void parseLayout(const JSVal&) override {}; void parsePaints(const JSVal&) override; + void cascade(const StyleCascadeParameters&) override; void recalculate(const StyleCalculationParameters&) override; std::unique_ptr createBucket(StyleBucketParameters&) const override; + bool hasTransitions() const override; + + ClassProperties layout; + PaintPropertiesMap paints; + CirclePaintProperties properties; }; diff --git a/src/mbgl/layer/fill_layer.cpp b/src/mbgl/layer/fill_layer.cpp index b5e072755..29982d933 100644 --- a/src/mbgl/layer/fill_layer.cpp +++ b/src/mbgl/layer/fill_layer.cpp @@ -5,6 +5,14 @@ namespace mbgl { +std::unique_ptr FillLayer::clone() const { + std::unique_ptr result = std::make_unique(); + result->copy(*this); + result->layout = layout; + result->paints.paints = paints.paints; + return std::move(result); +} + void FillLayer::parsePaints(const JSVal& layer) { paints.parseEach(layer, [&] (ClassProperties& paint, const JSVal& value) { parseProperty>("fill-antialias", PropertyKey::FillAntialias, paint, value); @@ -21,6 +29,14 @@ void FillLayer::parsePaints(const JSVal& layer) { }); } +void FillLayer::cascade(const StyleCascadeParameters& parameters) { + paints.cascade(parameters); +} + +bool FillLayer::hasTransitions() const { + return paints.hasTransitions(); +} + void FillLayer::recalculate(const StyleCalculationParameters& parameters) { paints.removeExpiredTransitions(parameters.now); diff --git a/src/mbgl/layer/fill_layer.hpp b/src/mbgl/layer/fill_layer.hpp index fd22efa82..dbab5e9a8 100644 --- a/src/mbgl/layer/fill_layer.hpp +++ b/src/mbgl/layer/fill_layer.hpp @@ -10,13 +10,21 @@ namespace mbgl { class FillLayer : public StyleLayer { public: + std::unique_ptr clone() const override; + void parseLayout(const JSVal&) override {}; void parsePaints(const JSVal&) override; + void cascade(const StyleCascadeParameters&) override; void recalculate(const StyleCalculationParameters&) override; std::unique_ptr createBucket(StyleBucketParameters&) const override; + bool hasTransitions() const override; + + ClassProperties layout; + PaintPropertiesMap paints; + FillPaintProperties properties; }; diff --git a/src/mbgl/layer/line_layer.cpp b/src/mbgl/layer/line_layer.cpp index d404c593c..6b98ffa9a 100644 --- a/src/mbgl/layer/line_layer.cpp +++ b/src/mbgl/layer/line_layer.cpp @@ -6,6 +6,14 @@ namespace mbgl { +std::unique_ptr LineLayer::clone() const { + std::unique_ptr result = std::make_unique(); + result->copy(*this); + result->layout = layout; + result->paints.paints = paints.paints; + return std::move(result); +} + void LineLayer::parseLayout(const JSVal& value) { parseProperty>("line-cap", PropertyKey::LineCap, layout, value); parseProperty>("line-join", PropertyKey::LineJoin, layout, value); @@ -33,6 +41,14 @@ void LineLayer::parsePaints(const JSVal& layer) { }); } +void LineLayer::cascade(const StyleCascadeParameters& parameters) { + paints.cascade(parameters); +} + +bool LineLayer::hasTransitions() const { + return paints.hasTransitions(); +} + void LineLayer::recalculate(const StyleCalculationParameters& parameters) { paints.removeExpiredTransitions(parameters.now); diff --git a/src/mbgl/layer/line_layer.hpp b/src/mbgl/layer/line_layer.hpp index 8acd58f01..1faf26b28 100644 --- a/src/mbgl/layer/line_layer.hpp +++ b/src/mbgl/layer/line_layer.hpp @@ -10,13 +10,21 @@ namespace mbgl { class LineLayer : public StyleLayer { public: + std::unique_ptr clone() const override; + void parseLayout(const JSVal&) override; void parsePaints(const JSVal&) override; + void cascade(const StyleCascadeParameters&) override; void recalculate(const StyleCalculationParameters&) override; std::unique_ptr createBucket(StyleBucketParameters&) const override; + bool hasTransitions() const override; + + ClassProperties layout; + PaintPropertiesMap paints; + LinePaintProperties properties; }; diff --git a/src/mbgl/layer/raster_layer.cpp b/src/mbgl/layer/raster_layer.cpp index 8649b58ab..f0bc94e3a 100644 --- a/src/mbgl/layer/raster_layer.cpp +++ b/src/mbgl/layer/raster_layer.cpp @@ -4,6 +4,14 @@ namespace mbgl { +std::unique_ptr RasterLayer::clone() const { + std::unique_ptr result = std::make_unique(); + result->copy(*this); + result->layout = layout; + result->paints.paints = paints.paints; + return std::move(result); +} + void RasterLayer::parsePaints(const JSVal& layer) { paints.parseEach(layer, [&] (ClassProperties& paint, const JSVal& value) { parseProperty>("raster-opacity", PropertyKey::RasterOpacity, paint, value); @@ -22,6 +30,14 @@ void RasterLayer::parsePaints(const JSVal& layer) { }); } +void RasterLayer::cascade(const StyleCascadeParameters& parameters) { + paints.cascade(parameters); +} + +bool RasterLayer::hasTransitions() const { + return paints.hasTransitions(); +} + void RasterLayer::recalculate(const StyleCalculationParameters& parameters) { paints.removeExpiredTransitions(parameters.now); diff --git a/src/mbgl/layer/raster_layer.hpp b/src/mbgl/layer/raster_layer.hpp index a5b09191a..543c6c8d0 100644 --- a/src/mbgl/layer/raster_layer.hpp +++ b/src/mbgl/layer/raster_layer.hpp @@ -10,13 +10,21 @@ namespace mbgl { class RasterLayer : public StyleLayer { public: + std::unique_ptr clone() const override; + void parseLayout(const JSVal&) override {}; void parsePaints(const JSVal&) override; + void cascade(const StyleCascadeParameters&) override; void recalculate(const StyleCalculationParameters&) override; std::unique_ptr createBucket(StyleBucketParameters&) const override; + bool hasTransitions() const override; + + ClassProperties layout; + PaintPropertiesMap paints; + RasterPaintProperties properties; }; diff --git a/src/mbgl/layer/symbol_layer.cpp b/src/mbgl/layer/symbol_layer.cpp index a82eae3aa..1e06a3ea7 100644 --- a/src/mbgl/layer/symbol_layer.cpp +++ b/src/mbgl/layer/symbol_layer.cpp @@ -7,6 +7,14 @@ namespace mbgl { +std::unique_ptr SymbolLayer::clone() const { + std::unique_ptr result = std::make_unique(); + result->copy(*this); + result->layout = layout; + result->paints.paints = paints.paints; + return std::move(result); +} + void SymbolLayer::parseLayout(const JSVal& value) { parseProperty>("symbol-placement", PropertyKey::SymbolPlacement, layout, value); parseProperty>("symbol-spacing", PropertyKey::SymbolSpacing, layout, value); @@ -77,6 +85,14 @@ void SymbolLayer::parsePaints(const JSVal& layer) { }); } +void SymbolLayer::cascade(const StyleCascadeParameters& parameters) { + paints.cascade(parameters); +} + +bool SymbolLayer::hasTransitions() const { + return paints.hasTransitions(); +} + void SymbolLayer::recalculate(const StyleCalculationParameters& parameters) { paints.removeExpiredTransitions(parameters.now); diff --git a/src/mbgl/layer/symbol_layer.hpp b/src/mbgl/layer/symbol_layer.hpp index 21f0f41d0..4fb662374 100644 --- a/src/mbgl/layer/symbol_layer.hpp +++ b/src/mbgl/layer/symbol_layer.hpp @@ -10,13 +10,21 @@ namespace mbgl { class SymbolLayer : public StyleLayer { public: + std::unique_ptr clone() const override; + void parseLayout(const JSVal&) override; void parsePaints(const JSVal&) override; + void cascade(const StyleCascadeParameters&) override; void recalculate(const StyleCalculationParameters&) override; std::unique_ptr createBucket(StyleBucketParameters&) const override; + bool hasTransitions() const override; + + ClassProperties layout; + PaintPropertiesMap paints; + SymbolPaintProperties properties; }; diff --git a/src/mbgl/style/paint_properties_map.cpp b/src/mbgl/style/paint_properties_map.cpp index 44513908c..4d7755ec3 100644 --- a/src/mbgl/style/paint_properties_map.cpp +++ b/src/mbgl/style/paint_properties_map.cpp @@ -2,10 +2,13 @@ #include #include #include +#include namespace mbgl { void PaintPropertiesMap::parseEach(const JSVal& layer, std::function parsePaint) { + paints.clear(); + rapidjson::Value::ConstMemberIterator itr = layer.MemberBegin(); for (; itr != layer.MemberEnd(); ++itr) { const std::string name { itr->name.GetString(), itr->name.GetStringLength() }; @@ -17,26 +20,24 @@ void PaintPropertiesMap::parseEach(const JSVal& layer, std::function& classes, - const TimePoint& now, - const PropertyTransition& defaultTransition) { +void PaintPropertiesMap::cascade(const StyleCascadeParameters& parameters) { // Stores all keys that we have already added transitions for. std::set alreadyApplied; // We only apply the default style values if there are no classes set. - if (classes.empty()) { - cascadeClass(ClassID::Default, alreadyApplied, now, defaultTransition); + if (parameters.classes.empty()) { + cascadeClass(ClassID::Default, alreadyApplied, parameters); return; } // Reverse iterate through all class names and apply them last to first. - for (auto it = classes.rbegin(); it != classes.rend(); ++it) { + for (auto it = parameters.classes.rbegin(); it != parameters.classes.rend(); ++it) { // From here on, we're only dealing with IDs to avoid comparing strings all the time. - cascadeClass(ClassDictionary::Get().lookup(*it), alreadyApplied, now, defaultTransition); + cascadeClass(ClassDictionary::Get().lookup(*it), alreadyApplied, parameters); } // As the last class, apply the default class. - cascadeClass(ClassID::Default, alreadyApplied, now, defaultTransition); + cascadeClass(ClassID::Default, alreadyApplied, parameters); // Make sure that we also transition to the fallback value for keys that aren't changed by // any applied classes. @@ -56,8 +57,8 @@ void PaintPropertiesMap::cascade(const std::vector& classes, // This property key hasn't been set by a previous class, so we need to add a transition // to the fallback value for that key. - const TimePoint begin = now + *defaultTransition.delay; - const TimePoint end = begin + *defaultTransition.duration; + const TimePoint begin = parameters.now + *parameters.defaultTransition.delay; + const TimePoint end = begin + *parameters.defaultTransition.duration; const PropertyValue &value = PropertyFallbackValue::Get(key); appliedProperties.add(ClassID::Fallback, begin, end, value); } @@ -65,8 +66,7 @@ void PaintPropertiesMap::cascade(const std::vector& classes, void PaintPropertiesMap::cascadeClass(const ClassID classID, std::set& alreadyApplied, - const TimePoint& now, - const PropertyTransition& defaultTransition) { + const StyleCascadeParameters& parameters) { auto styleIt = paints.find(classID); if (styleIt == paints.end()) { // There is no class in this layer with this class_name. @@ -92,9 +92,9 @@ void PaintPropertiesMap::cascadeClass(const ClassID classID, AppliedClassPropertyValues &appliedProperties = appliedStyle[key]; if (appliedProperties.mostRecent() != classID) { PropertyTransition transition = classProperties.getTransition(key); - Duration delay = transition.delay ? *transition.delay : *defaultTransition.delay; - Duration duration = transition.duration ? *transition.duration : *defaultTransition.duration; - const TimePoint begin = now + delay; + Duration delay = transition.delay ? *transition.delay : *parameters.defaultTransition.delay; + Duration duration = transition.duration ? *transition.duration : *parameters.defaultTransition.duration; + const TimePoint begin = parameters.now + delay; const TimePoint end = begin + duration; const PropertyValue &value = propertyPair.second; appliedProperties.add(classID, begin, end, value); diff --git a/src/mbgl/style/paint_properties_map.hpp b/src/mbgl/style/paint_properties_map.hpp index 26fd8301b..e32f723d8 100644 --- a/src/mbgl/style/paint_properties_map.hpp +++ b/src/mbgl/style/paint_properties_map.hpp @@ -18,14 +18,13 @@ namespace mbgl { class ClassProperties; class PropertyTransition; +class StyleCascadeParameters; using JSVal = rapidjson::Value; class PaintPropertiesMap { public: - void cascade(const std::vector& classNames, - const TimePoint& now, - const PropertyTransition& defaultTransition); + void cascade(const StyleCascadeParameters&); bool hasTransitions() const; void removeExpiredTransitions(const TimePoint& now); @@ -81,8 +80,7 @@ private: // Applies all properties from a class, if they haven't been applied already. void cascadeClass(const ClassID, std::set&, - const TimePoint&, - const PropertyTransition&); + const StyleCascadeParameters&); // For every property, stores a list of applied property values, with // optional transition times. diff --git a/src/mbgl/style/style.cpp b/src/mbgl/style/style.cpp index 921715d2d..b7d6f6166 100644 --- a/src/mbgl/style/style.cpp +++ b/src/mbgl/style/style.cpp @@ -7,6 +7,8 @@ #include #include #include +#include +#include #include #include #include @@ -119,10 +121,13 @@ void Style::update(const TransformState& transform, } void Style::cascade() { + StyleCascadeParameters parameters(data.getClasses(), + data.getAnimationTime(), + PropertyTransition { data.getDefaultTransitionDuration(), + data.getDefaultTransitionDelay() }); + for (const auto& layer : layers) { - layer->cascade(data.getClasses(), - data.getAnimationTime(), - PropertyTransition { data.getDefaultTransitionDuration(), data.getDefaultTransitionDelay() }); + layer->cascade(parameters); } } diff --git a/src/mbgl/style/style_cascade_parameters.hpp b/src/mbgl/style/style_cascade_parameters.hpp new file mode 100644 index 000000000..406491037 --- /dev/null +++ b/src/mbgl/style/style_cascade_parameters.hpp @@ -0,0 +1,28 @@ +#ifndef STYLE_CASCADE_PARAMETERS +#define STYLE_CASCADE_PARAMETERS + +#include + +#include + +namespace mbgl { + +class PropertyTransition; + +class StyleCascadeParameters { +public: + StyleCascadeParameters(const std::vector& classes_, + const TimePoint& now_, + const PropertyTransition& defaultTransition_) + : classes(classes_), + now(now_), + defaultTransition(defaultTransition_) {} + + std::vector classes; + TimePoint now; + PropertyTransition defaultTransition; +}; + +} + +#endif diff --git a/src/mbgl/style/style_layer.cpp b/src/mbgl/style/style_layer.cpp index bd8202054..1b3d1a3c3 100644 --- a/src/mbgl/style/style_layer.cpp +++ b/src/mbgl/style/style_layer.cpp @@ -31,18 +31,18 @@ const std::string& StyleLayer::bucketName() const { return ref.empty() ? id : ref; } -void StyleLayer::cascade(const std::vector& classes, - const TimePoint& now, - const PropertyTransition& defaultTransition) { - paints.cascade(classes, now, defaultTransition); -} - -bool StyleLayer::hasTransitions() const { - return paints.hasTransitions(); -} - bool StyleLayer::hasRenderPass(RenderPass pass) const { return bool(passes & pass); } +void StyleLayer::copy(const StyleLayer& src) { + type = src.type; + source = src.source; + sourceLayer = src.sourceLayer; + filter = src.filter; + minZoom = src.minZoom; + maxZoom = src.maxZoom; + visibility = src.visibility; +} + } diff --git a/src/mbgl/style/style_layer.hpp b/src/mbgl/style/style_layer.hpp index 191c239a1..3e8662575 100644 --- a/src/mbgl/style/style_layer.hpp +++ b/src/mbgl/style/style_layer.hpp @@ -3,32 +3,26 @@ #include #include -#include -#include - #include -#include - #include -#include -#include #include -#include #include namespace mbgl { +class StyleCascadeParameters; class StyleCalculationParameters; class StyleBucketParameters; -class PropertyTransition; +class Bucket; using JSVal = rapidjson::Value; class StyleLayer : public util::noncopyable { public: static std::unique_ptr create(StyleLayerType); + virtual std::unique_ptr clone() const = 0; virtual ~StyleLayer() = default; @@ -39,9 +33,7 @@ public: const std::string& bucketName() const; // Partially evaluate paint properties based on a set of classes. - void cascade(const std::vector& classNames, - const TimePoint& now, - const PropertyTransition& defaultTransition); + virtual void cascade(const StyleCascadeParameters&) = 0; // Fully evaluate cascaded paint properties based on a zoom level. virtual void recalculate(const StyleCalculationParameters&) = 0; @@ -49,7 +41,7 @@ public: virtual std::unique_ptr createBucket(StyleBucketParameters&) const = 0; // Checks whether this layer has any active paint properties with transitions. - bool hasTransitions() const; + virtual bool hasTransitions() const = 0; // Checks whether this layer needs to be rendered in the given render pass. bool hasRenderPass(RenderPass) const; @@ -64,13 +56,13 @@ public: float minZoom = -std::numeric_limits::infinity(); float maxZoom = std::numeric_limits::infinity(); VisibilityType visibility = VisibilityType::Visible; - ClassProperties layout; - PaintPropertiesMap paints; protected: // Stores what render passes this layer is currently enabled for. This depends on the // evaluated StyleProperties object and is updated accordingly. RenderPass passes = RenderPass::None; + + void copy(const StyleLayer& source); }; } diff --git a/src/mbgl/style/style_parser.cpp b/src/mbgl/style/style_parser.cpp index 6a738261a..41dbb74b3 100644 --- a/src/mbgl/style/style_parser.cpp +++ b/src/mbgl/style/style_parser.cpp @@ -184,16 +184,9 @@ void StyleParser::parseLayer(const std::string& id, const JSVal& value, util::pt return; } - layer = StyleLayer::create(reference->type); + layer = reference->clone(); layer->id = id; - layer->type = reference->type; - layer->source = reference->source; - layer->sourceLayer = reference->sourceLayer; - layer->filter = reference->filter; - layer->minZoom = reference->minZoom; - layer->maxZoom = reference->maxZoom; - layer->visibility = reference->visibility; - layer->layout = reference->layout; + layer->ref = ref; } else { // Otherwise, parse the source/source-layer/filter/render keys to form the bucket.