Add clang-format (#1086)

Co-authored-by: mwilsnd <mwilsnd@gmail.com>
This commit is contained in:
Bart Louwers
2023-05-01 16:57:37 +02:00
committed by GitHub
parent 403a12bd1b
commit 71f6da2722
1018 changed files with 27876 additions and 25862 deletions

View File

@@ -38,7 +38,7 @@ void updateRenderables(GetTileFn getTile,
tile = createTile(idealDataTileID);
// For source types where TileJSON.bounds is set, tiles outside the
// bounds are not created
if(tile == nullptr) {
if (tile == nullptr) {
continue;
}
}
@@ -75,8 +75,8 @@ void updateRenderables(GetTileFn getTile,
retainTile(*tile, TileNecessity::Optional);
renderTile(childDataTileID.toUnwrapped(), *tile);
} else {
// At least one child tile doesn't exist, so we are going to look for
// parents as well.
// At least one child tile doesn't exist, so we are
// going to look for parents as well.
covered = false;
}
}
@@ -87,15 +87,16 @@ void updateRenderables(GetTileFn getTile,
for (overscaledZ = idealDataTileID.overscaledZ - 1; overscaledZ >= zoomRange.min; --overscaledZ) {
const auto parentDataTileID = idealDataTileID.scaledTo(overscaledZ);
// Request / render parent tile only if it's overscale factor is less than defined maximum.
// Request / render parent tile only if it's overscale
// factor is less than defined maximum.
if (maxParentOverscaleFactor &&
(idealDataTileID.overscaledZ - overscaledZ) > *maxParentOverscaleFactor) {
break;
}
if (checked.find(parentDataTileID) != checked.end()) {
// Break parent tile ascent, this route has been checked by another child
// tile before.
// Break parent tile ascent, this route has been checked
// by another child tile before.
break;
} else {
checked.emplace(parentDataTileID);
@@ -108,17 +109,19 @@ void updateRenderables(GetTileFn getTile,
if (tile) {
if (!parentIsLoaded) {
// We haven't completed loading the child, so we only do an optional
// (cache) request in an attempt to quickly load data that we can show.
// We haven't completed loading the child, so we
// only do an optional (cache) request in an attempt
// to quickly load data that we can show.
retainTile(*tile, TileNecessity::Optional);
} else {
// Now that we've checked the child and know for sure that we can't load
// it, we attempt to load the parent from the network.
// Now that we've checked the child and know for
// sure that we can't load it, we attempt to load
// the parent from the network.
retainTile(*tile, TileNecessity::Required);
}
// Save the current values, since they're the parent of the next iteration
// of the parent tile ascent loop.
// Save the current values, since they're the parent of
// the next iteration of the parent tile ascent loop.
parentHasTriedOptional = tile->hasTriedCache();
parentIsLoaded = tile->isLoaded();

View File

@@ -10,21 +10,27 @@ namespace mbgl {
namespace algorithm {
template <typename T>
bool tileNeedsMask(const std::reference_wrapper<T>& tile) { return tile.get().usedByRenderedLayers; }
template <typename T>
void setTileMask(const std::reference_wrapper<T>& tile, TileMask&& mask ) { return tile.get().setMask(std::move(mask)); }
bool tileNeedsMask(const std::reference_wrapper<T>& tile) {
return tile.get().usedByRenderedLayers;
}
template <typename T>
void setTileMask(const std::reference_wrapper<T>& tile, TileMask&& mask) {
return tile.get().setMask(std::move(mask));
}
// Overloads for tests
template <typename T> bool tileNeedsMask(const T& tile) { return tile.usedByRenderedLayers; }
template <typename T> void setTileMask(T& tile, TileMask&& mask ) { return tile.setMask(std::move(mask)); }
template <typename T>
bool tileNeedsMask(const T& tile) {
return tile.usedByRenderedLayers;
}
template <typename T>
void setTileMask(T& tile, TileMask&& mask) {
return tile.setMask(std::move(mask));
}
template <typename Iterator>
void computeTileMasks(
const CanonicalTileID& root,
const UnwrappedTileID& ref,
const Iterator begin,
const Iterator end,
TileMask& mask) {
const CanonicalTileID& root, const UnwrappedTileID& ref, const Iterator begin, const Iterator end, TileMask& mask) {
// If the reference or any of its children is found in the list, we need to recurse.
for (auto it = begin; it != end; ++it) {
const UnwrappedTileID& id = it->first;
@@ -35,7 +41,7 @@ void computeTileMasks(
if (ref == id) {
// The current tile is masked out, so we don't need to add them to the mask set.
return;
}
}
if (id.isChildOf(ref)) {
// There's at least one child tile that is masked out, so recursively descend.
@@ -47,17 +53,19 @@ void computeTileMasks(
}
// We couldn't find a child, so it's definitely a masked part.
// Compute the difference between the root tile ID and the reference tile ID, since TileMask
// elements are always relative (see below for explanation).
// Compute the difference between the root tile ID and the reference tile
// ID, since TileMask elements are always relative (see below for
// explanation).
const uint8_t diffZ = ref.canonical.z - root.z;
mask.emplace(diffZ, ref.canonical.x - (root.x << diffZ), ref.canonical.y - (root.y << diffZ));
}
// Updates the TileMasks for all renderable tiles. Each renderable tile has a corresponding UnwrappedTileID
// indicating where it should be rendered on the screen. A TileMask describes all regions
// within a renderable tile that are *not* covered by other renderable tiles.
// Example: Renderable tiles in our list are 2/1/3, 3/3/6, and 4/5/13. The schematic for creating the
// TileMask for 2/1/3 looks like this:
// Updates the TileMasks for all renderable tiles. Each renderable tile has a
// corresponding UnwrappedTileID indicating where it should be rendered on the
// screen. A TileMask describes all regions within a renderable tile that are
// *not* covered by other renderable tiles. Example: Renderable tiles in our
// list are 2/1/3, 3/3/6, and 4/5/13. The schematic for creating the TileMask
// for 2/1/3 looks like this:
//
// ┌────────┬────────┬─────────────────┐
// │ │ │#################│
@@ -77,10 +85,11 @@ void computeTileMasks(
// │ │ │
// └─────────────────┴─────────────────┘
//
// The TileMask for 2/1/3 thus consists of the tiles 4/4/12, 4/5/12, 4/4/13, 3/2/7, and 3/3/7,
// but it does *not* include 4/5/13, and 3/3/6, since these are other renderable tiles.
// A TileMask always contains TileIDs *relative* to the tile it is generated for, so 2/1/3 is
// "subtracted" from these TileIDs. The final TileMask for 2/1/3 will thus be:
// The TileMask for 2/1/3 thus consists of the tiles 4/4/12, 4/5/12, 4/4/13,
// 3/2/7, and 3/3/7, but it does *not* include 4/5/13, and 3/3/6, since these
// are other renderable tiles. A TileMask always contains TileIDs *relative* to
// the tile it is generated for, so 2/1/3 is "subtracted" from these TileIDs.
// The final TileMask for 2/1/3 will thus be:
//
// ┌────────┬────────┬─────────────────┐
// │ │ │#################│
@@ -100,9 +109,10 @@ void computeTileMasks(
// │ │ │
// └─────────────────┴─────────────────┘
//
// Only other renderable tiles that are *children* of the renderable tile we are generating the mask for will
// will be considered. For example, adding a renderable tile with TileID 4/8/13 won't affect the TileMask for
// 2/1/3, since it is not a descendant of it.
// Only other renderable tiles that are *children* of the renderable tile we are
// generating the mask for will will be considered. For example, adding a
// renderable tile with TileID 4/8/13 won't affect the TileMask for 2/1/3, since
// it is not a descendant of it.
template <typename RenderableTilesMap>
void updateTileMasks(RenderableTilesMap& renderables) {
TileMask mask;
@@ -113,14 +123,15 @@ void updateTileMasks(RenderableTilesMap& renderables) {
continue;
}
// Try to add all remaining ids as children. We sorted the tile list
// by z earlier, so all preceding items cannot be children of the current
// tile. We also compute the lower bound of the next wrap, because items of the next wrap
// can never be children of the current wrap.
// by z earlier, so all preceding items cannot be children of the
// current tile. We also compute the lower bound of the next wrap,
// because items of the next wrap can never be children of the current
// wrap.
auto child_it = std::next(it);
const auto children_end = std::lower_bound(
child_it, end,
UnwrappedTileID{ static_cast<int16_t>(id.wrap + 1), { 0, 0, 0 } },
[](auto& a, auto& b) { return a.first < b; });
child_it, end, UnwrappedTileID{static_cast<int16_t>(id.wrap + 1), {0, 0, 0}}, [](auto& a, auto& b) {
return a.first < b;
});
mask.clear();
computeTileMasks(id.canonical, id, child_it, children_end, mask);