From 655e12a5b6b117a4caad52d127d86d6be1a22b9c Mon Sep 17 00:00:00 2001 From: Bart Louwers Date: Wed, 4 Oct 2023 14:00:40 +0000 Subject: [PATCH] Remove clear() method --- include/mbgl/util/string_indexer.hpp | 2 -- src/mbgl/util/string_indexer.cpp | 8 -------- test/util/string_indexer.test.cpp | 4 ++++ 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/include/mbgl/util/string_indexer.hpp b/include/mbgl/util/string_indexer.hpp index 1067a32b0..bd4d8162c 100644 --- a/include/mbgl/util/string_indexer.hpp +++ b/include/mbgl/util/string_indexer.hpp @@ -26,8 +26,6 @@ public: std::string get(const StringIdentity id); - void clear(); - size_t size(); protected: diff --git a/src/mbgl/util/string_indexer.cpp b/src/mbgl/util/string_indexer.cpp index 19ffde6a2..0ead2f6a6 100644 --- a/src/mbgl/util/string_indexer.cpp +++ b/src/mbgl/util/string_indexer.cpp @@ -67,14 +67,6 @@ std::string StringIndexer::get(const StringIdentity id) { return id < identityToString.size() ? (buffer.data() + identityToString[id]) : empty; } -void StringIndexer::clear() { - std::unique_lock writerLock(sharedMutex); - - stringToIdentity.clear(); - identityToString.clear(); - buffer.clear(); -} - size_t StringIndexer::size() { std::shared_lock readerLock(sharedMutex); diff --git a/test/util/string_indexer.test.cpp b/test/util/string_indexer.test.cpp index 9155f44b8..60ed60f65 100644 --- a/test/util/string_indexer.test.cpp +++ b/test/util/string_indexer.test.cpp @@ -6,6 +6,10 @@ using namespace mbgl; +TEST(StringIndexer, SingletonStringIndexer) { + EXPECT_GE(stringIndexer().size(), 0); +} + TEST(StringIndexer, AddStrings) { StringIndexer strIndexer; EXPECT_EQ(strIndexer.size(), 0);