diff --git a/include/mbgl/map/camera.hpp b/include/mbgl/map/camera.hpp index c8b665fc1..726c00923 100644 --- a/include/mbgl/map/camera.hpp +++ b/include/mbgl/map/camera.hpp @@ -89,7 +89,7 @@ struct AnimationOptions { std::function transitionFinishFn; /** Creates an animation with no options specified. */ - AnimationOptions() {} + AnimationOptions() = default; /** Creates an animation with the specified duration. */ AnimationOptions(Duration d) diff --git a/include/mbgl/style/filter.hpp b/include/mbgl/style/filter.hpp index 5e14bccac..c3ce6833f 100644 --- a/include/mbgl/style/filter.hpp +++ b/include/mbgl/style/filter.hpp @@ -18,7 +18,7 @@ public: private: optional legacyFilter; public: - Filter() {} + Filter() = default; Filter(expression::ParseResult _expression, optional _filter = {}) : expression(std::move(*_expression)), diff --git a/platform/node/src/node_map.hpp b/platform/node/src/node_map.hpp index 4349cbabe..29c4547b2 100644 --- a/platform/node/src/node_map.hpp +++ b/platform/node/src/node_map.hpp @@ -97,7 +97,7 @@ public: struct NodeFileSource : public mbgl::FileSource { NodeFileSource(NodeMap* nodeMap_) : nodeMap(nodeMap_) {} - ~NodeFileSource() {} + ~NodeFileSource() = default; std::unique_ptr request(const mbgl::Resource&, mbgl::FileSource::Callback) final; bool canRequest(const mbgl::Resource&) const override; NodeMap* nodeMap; diff --git a/platform/node/src/util/async_queue.hpp b/platform/node/src/util/async_queue.hpp index a084b866a..e9d9e2362 100644 --- a/platform/node/src/util/async_queue.hpp +++ b/platform/node/src/util/async_queue.hpp @@ -22,7 +22,7 @@ public: q->process(); }); } - ~AsyncQueue() {} + ~AsyncQueue() = default; void send(T &&data) { { diff --git a/src/mbgl/layout/symbol_projection.hpp b/src/mbgl/layout/symbol_projection.hpp index e04f8908b..598073bf5 100644 --- a/src/mbgl/layout/symbol_projection.hpp +++ b/src/mbgl/layout/symbol_projection.hpp @@ -30,8 +30,7 @@ namespace mbgl { {} PlacedGlyph(PlacedGlyph&& other) noexcept : point(other.point), angle(other.angle), tileDistance(std::move(other.tileDistance)) {} - PlacedGlyph(const PlacedGlyph& other) - : point(other.point), angle(other.angle), tileDistance(other.tileDistance) {} + PlacedGlyph(const PlacedGlyph& other) = default; Point point; float angle; optional tileDistance; diff --git a/src/mbgl/text/collision_feature.hpp b/src/mbgl/text/collision_feature.hpp index f9ad65957..248660083 100644 --- a/src/mbgl/text/collision_feature.hpp +++ b/src/mbgl/text/collision_feature.hpp @@ -36,9 +36,10 @@ public: private: union Geometry { + // NOLINTNEXTLINE(modernize-use-equals-default) + Geometry() {} Geometry(float x1, float y1, float x2, float y2) : box({x1, y1}, {x2, y2}) {} Geometry(float x, float y, float r) : circle({x, y}, r) {} - Geometry() {} mapbox::geometry::box box; geometry::circle circle; } geometry;