From 4f3485f31aca0b466e44e5e87dfca59e6715eb79 Mon Sep 17 00:00:00 2001
From: Bart Louwers <bart@emeel.net>
Date: Thu, 13 Jun 2024 17:31:23 +0200
Subject: [PATCH] Add -fvisibility=hidden flag to Bazel (#2502)

---
 bazel/flags.bzl                             |  4 +-
 platform/ios/test/CI-Expressions.xctestplan | 67 ---------------------
 platform/ios/test/CI.xctestplan             | 46 --------------
 3 files changed, 3 insertions(+), 114 deletions(-)
 delete mode 100644 platform/ios/test/CI-Expressions.xctestplan
 delete mode 100644 platform/ios/test/CI.xctestplan

diff --git a/bazel/flags.bzl b/bazel/flags.bzl
index f9c6559d6..6855a35cb 100644
--- a/bazel/flags.bzl
+++ b/bazel/flags.bzl
@@ -98,7 +98,9 @@ MSVC_CPP_FLAGS = [
 ]
 
 CPP_FLAGS = select({
-    "//conditions:default": GCC_CLANG_CPP_FLAGS + WARNING_FLAGS["ios"],
+    "//conditions:default": GCC_CLANG_CPP_FLAGS,
+    "@platforms//os:ios": GCC_CLANG_CPP_FLAGS + WARNING_FLAGS["ios"] + ["-fvisibility=hidden"],
+    "@platforms//os:macos": GCC_CLANG_CPP_FLAGS + WARNING_FLAGS["macos"] + ["-fvisibility=hidden"],
     "@platforms//os:linux": GCC_CLANG_CPP_FLAGS + WARNING_FLAGS["linux"],
     "@platforms//os:windows": MSVC_CPP_FLAGS + WARNING_FLAGS["windows"],
 })
diff --git a/platform/ios/test/CI-Expressions.xctestplan b/platform/ios/test/CI-Expressions.xctestplan
deleted file mode 100644
index 1cd693e00..000000000
--- a/platform/ios/test/CI-Expressions.xctestplan
+++ /dev/null
@@ -1,67 +0,0 @@
-{
-  "configurations" : [
-    {
-      "id" : "5BA24211-C310-4541-954F-761180BB7D62",
-      "name" : "Configuration 1",
-      "options" : {
-
-      }
-    }
-  ],
-  "defaultOptions" : {
-    "testTimeoutsEnabled" : true
-  },
-  "testTargets" : [
-    {
-      "skippedTests" : [
-        "MLNAnnotationViewIntegrationTests",
-        "MLNAnnotationViewTests",
-        "MLNAttributionInfoTests",
-        "MLNClockDirectionFormatterTests",
-        "MLNCodingTests",
-        "MLNCompassButtonTests",
-        "MLNCompassDirectionFormatterTests",
-        "MLNComputedShapeSourceTests",
-        "MLNCoordinateFormatterTests",
-        "MLNDistanceFormatterTests",
-        "MLNFeatureTests",
-        "MLNGeometryTests",
-        "MLNImageSourceTests",
-        "MLNImageTests",
-        "MLNLightTest",
-        "MLNMapAccessibilityElementTests",
-        "MLNMapCameraTests",
-        "MLNMapProjectionTests",
-        "MLNMapSnapshotterTests",
-        "MLNMapViewContentInsetTests",
-        "MLNMapViewDelegateIntegrationTests",
-        "MLNMapViewDirectionTests",
-        "MLNMapViewGestureRecognizerTests",
-        "MLNMapViewLayoutTests",
-        "MLNMapViewPitchTests",
-        "MLNMapViewScaleBarTests",
-        "MLNMapViewTests",
-        "MLNMapViewZoomTests",
-        "MLNNSDateAdditionsTests",
-        "MLNNSOrthographyAdditionsTests",
-        "MLNNSStringAdditionsTests",
-        "MLNNetworkConfigurationTests",
-        "MLNOfflinePackTests",
-        "MLNOfflineRegionTests",
-        "MLNOfflineStorageTests",
-        "MLNRendererConfigurationTests",
-        "MLNResourceTests",
-        "MLNSourceQueryTests",
-        "MLNStyleTests",
-        "MLNTileSetTests",
-        "MLNVersionTests"
-      ],
-      "target" : {
-        "containerPath" : "container:ios.xcodeproj",
-        "identifier" : "DA2E88501CC036F400F24E7B",
-        "name" : "test"
-      }
-    }
-  ],
-  "version" : 1
-}
diff --git a/platform/ios/test/CI.xctestplan b/platform/ios/test/CI.xctestplan
deleted file mode 100644
index aa53e5c64..000000000
--- a/platform/ios/test/CI.xctestplan
+++ /dev/null
@@ -1,46 +0,0 @@
-{
-  "configurations" : [
-    {
-      "id" : "BEEEA5EA-93DE-449D-9090-A692034EA702",
-      "name" : "Configuration 1",
-      "options" : {
-
-      }
-    }
-  ],
-  "defaultOptions" : {
-    "codeCoverage" : {
-      "targets" : [
-        {
-          "containerPath" : "container:ios.xcodeproj",
-          "identifier" : "DA8847D11CBAF91600AB86E3",
-          "name" : "dynamic"
-        }
-      ]
-    },
-    "environmentVariableEntries" : [
-      {
-        "enabled" : false,
-        "key" : "MAPBOX_RUN_PENDING_TESTS",
-        "value" : "YES"
-      }
-    ],
-    "language" : "en",
-    "region" : "US"
-  },
-  "testTargets" : [
-    {
-      "skippedTests" : [
-        "MLNMapSnapshotterTests\/testLocalGlyphRendering",
-        "MLNOfflineStorageTests",
-        "MLNMapViewContentInsetTests"
-      ],
-      "target" : {
-        "containerPath" : "container:ios.xcodeproj",
-        "identifier" : "DA2E88501CC036F400F24E7B",
-        "name" : "test"
-      }
-    }
-  ],
-  "version" : 1
-}