From 44490f620cd19624a9689a45450f9fb33e33c06c Mon Sep 17 00:00:00 2001 From: Mike Morris Date: Wed, 27 May 2015 18:24:43 -0400 Subject: [PATCH] drop SetAccessToken from NodeMap Handle this is JavaScript where necessary. --- src/node_map.cpp | 25 +------------------------ src/node_map.hpp | 1 - vendor/mbgl | 2 +- 3 files changed, 2 insertions(+), 26 deletions(-) diff --git a/src/node_map.cpp b/src/node_map.cpp index c5dde6053..4dc39b729 100644 --- a/src/node_map.cpp +++ b/src/node_map.cpp @@ -38,7 +38,6 @@ void NodeMap::Init(v8::Handle target) { t->InstanceTemplate()->SetInternalFieldCount(1); t->SetClassName(NanNew("Map")); - NODE_SET_PROTOTYPE_METHOD(t, "setAccessToken", SetAccessToken); NODE_SET_PROTOTYPE_METHOD(t, "load", Load); NODE_SET_PROTOTYPE_METHOD(t, "render", Render); @@ -83,27 +82,6 @@ NAN_METHOD(NodeMap::New) { } -NAN_METHOD(NodeMap::SetAccessToken) { - NanScope(); - - if (args.Length() < 1) { - return NanThrowError("Requires a string as first argument"); - } - - NanUtf8String token(args[0]); - - auto nodeMap = node::ObjectWrap::Unwrap(args.Holder()); - - try { - nodeMap->map.setAccessToken(std::string { *token, size_t(token.length()) }); - } catch (const std::exception &ex) { - return NanThrowError(ex.what()); - } - - - NanReturnUndefined(); -} - const std::string StringifyStyle(v8::Handle styleHandle) { NanScope(); @@ -125,8 +103,7 @@ NAN_METHOD(NodeMap::Load) { if (args[0]->IsObject()) { style = StringifyStyle(args[0]); } else if (args[0]->IsString()) { - NanUtf8String string(args[0]); - style = { *string, size_t(string.length()) }; + style = *NanUtf8String(args[0]); } else { return NanThrowTypeError("First argument must be a string or object"); } diff --git a/src/node_map.hpp b/src/node_map.hpp index 1cb32e40d..ecba02867 100644 --- a/src/node_map.hpp +++ b/src/node_map.hpp @@ -25,7 +25,6 @@ class NodeMap : public node::ObjectWrap { public: static void Init(v8::Handle target); static NAN_METHOD(New); - static NAN_METHOD(SetAccessToken); static NAN_METHOD(Load); static NAN_METHOD(Render); diff --git a/vendor/mbgl b/vendor/mbgl index a20b89e4f..9dd8d2672 160000 --- a/vendor/mbgl +++ b/vendor/mbgl @@ -1 +1 @@ -Subproject commit a20b89e4ff991b650c7b09e203c2fee5c8e0c62b +Subproject commit 9dd8d26729eba5ecb8d788b8ba2150cf5b4bdeca