From 42c233b8b45c25dc41a989c68bd71a3ced3ac2b5 Mon Sep 17 00:00:00 2001
From: Dane Springmeyer <dane@mapbox.com>
Date: Thu, 29 May 2014 12:32:54 -0700
Subject: [PATCH] fix -Wformat-security warning with dodgy fprintf

---
 common.gypi              | 14 +++++++++++---
 src/text/glyph_store.cpp |  2 +-
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/common.gypi b/common.gypi
index b1ad46015..a3e4e5e2f 100644
--- a/common.gypi
+++ b/common.gypi
@@ -5,6 +5,11 @@
       'CLANG_CXX_LIBRARY': 'libc++',
       'CLANG_CXX_LANGUAGE_STANDARD':'c++11',
       'GCC_VERSION': 'com.apple.compilers.llvm.clang.1_0',
+      'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',
+      'GCC_ENABLE_CPP_RTTI':'YES',
+      'OTHER_CPLUSPLUSFLAGS': [ '-Wall', '-Wextra' ],
+      'GCC_WARN_PEDANTIC': 'YES',
+      'GCC_WARN_UNINITIALIZED_AUTOS': 'YES_AGGRESSIVE'
     },
     'cflags_cc': ['-std=c++11'],
     'configurations': {
@@ -14,7 +19,11 @@
         'xcode_settings': {
           'GCC_OPTIMIZATION_LEVEL': '0',
           'GCC_GENERATE_DEBUGGING_SYMBOLS': 'YES',
-          'OTHER_CPLUSPLUSFLAGS': [ '-Wall', '-Wextra', '-pedantic' ]
+          'DEAD_CODE_STRIPPING': 'NO',
+          'GCC_INLINES_ARE_PRIVATE_EXTERN': 'NO',
+          'RUN_CLANG_STATIC_ANALYZER':'YES',
+          'CLANG_ANALYZER_SECURITY_INSECUREAPI_STRCPY': 'YES',
+          'CLANG_ANALYZER_SECURITY_FLOATLOOPCOUNTER': 'YES'
         }
       },
       'Release': {
@@ -24,8 +33,7 @@
           'GCC_OPTIMIZATION_LEVEL': '3',
           'GCC_GENERATE_DEBUGGING_SYMBOLS': 'NO',
           'DEAD_CODE_STRIPPING': 'YES',
-          'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES',
-          'OTHER_CPLUSPLUSFLAGS': [ '-Wall', '-Wextra', '-pedantic' ]
+          'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES'
         }
       }
     }
diff --git a/src/text/glyph_store.cpp b/src/text/glyph_store.cpp
index e0404c08d..3f741236f 100644
--- a/src/text/glyph_store.cpp
+++ b/src/text/glyph_store.cpp
@@ -52,7 +52,7 @@ GlyphPBF::GlyphPBF(const std::string &fontStack, GlyphRange glyphRange)
     // TODO: Find more reliable URL normalization function
     std::replace(url.begin(), url.end(), ' ', '+');
 
-    fprintf(stderr, url.c_str());
+    fprintf(stderr, "%s\n", url.c_str());
 
     platform::request_http(url, [&](platform::Response *res) {
         if (res->code != 200) {