From 42469cdb6655ded30367b2add553265770949d86 Mon Sep 17 00:00:00 2001 From: Aleksandar Stojiljkovic Date: Sun, 1 Mar 2020 09:58:08 +0200 Subject: [PATCH] Disable depth in heatmap offscreen rendering. It triggers Metal depth stencil validation error since depth test is enabled with no depth attachment. --- .../renderer/layers/render_heatmap_layer.cpp | 28 +++++++++---------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/src/mbgl/renderer/layers/render_heatmap_layer.cpp b/src/mbgl/renderer/layers/render_heatmap_layer.cpp index 5f3c36e44..03a7d12fc 100644 --- a/src/mbgl/renderer/layers/render_heatmap_layer.cpp +++ b/src/mbgl/renderer/layers/render_heatmap_layer.cpp @@ -130,21 +130,19 @@ void RenderHeatmapLayer::render(PaintParameters& parameters) { checkRenderability(parameters, programInstance.activeBindingCount(allAttributeBindings)); - programInstance.draw( - parameters.context, - *renderPass, - gfx::Triangles(), - parameters.depthModeForSublayer(0, gfx::DepthMaskType::ReadOnly), - gfx::StencilMode::disabled(), - gfx::ColorMode::additive(), - gfx::CullFaceMode::disabled(), - *bucket.indexBuffer, - bucket.segments, - allUniformValues, - allAttributeBindings, - HeatmapProgram::TextureBindings{}, - getID() - ); + programInstance.draw(parameters.context, + *renderPass, + gfx::Triangles(), + gfx::DepthMode::disabled(), + gfx::StencilMode::disabled(), + gfx::ColorMode::additive(), + gfx::CullFaceMode::disabled(), + *bucket.indexBuffer, + bucket.segments, + allUniformValues, + allAttributeBindings, + HeatmapProgram::TextureBindings{}, + getID()); } } else if (parameters.pass == RenderPass::Translucent) {