Fix Linux render test CI failure showing up as pass (#1384)

This commit is contained in:
Bart Louwers
2023-07-17 11:56:24 +02:00
committed by GitHub
parent 236614235a
commit 3f81dc3f1f
2 changed files with 4 additions and 3 deletions

View File

@@ -160,17 +160,18 @@ jobs:
- run: chmod +x ./mbgl-render-test-runner
- name: Run render test
continue-on-error: true
id: render_test
run: xvfb-run -a ./mbgl-render-test-runner --manifestPath=metrics/linux-gcc8-release-style.json
- name: Save PR number
if: always() && steps.render_test.outcome != 'failure'
env:
PR_NUMBER: ${{ github.event.number }}
run: |
echo $PR_NUMBER > ./pr_number
- name: Upload render test result
if: always() && steps.render_test.outcome != 'failure'
uses: actions/upload-artifact@v3
with:
name: render-test-result

View File

@@ -13,11 +13,11 @@ on:
jobs:
upload-render-test-result:
runs-on: ubuntu-22.04
if: github.event.workflow_run.event == 'pull_request'
if: github.event.workflow_run.event == 'pull_request' && github.event.workflow_run.conclusion == 'failure'
steps:
- uses: actions/checkout@v3
- uses: .github/actions/download-workflow-run-artifact
- uses: ./.github/actions/download-workflow-run-artifact
with:
artifact-name: render-test-result
expect-files: "./pr_number, metrics/linux-gcc8-release-style.html"