[core] Check all bucket dynamic_casts

A mismatch can occur when a layer changes from one type to another.
This commit is contained in:
John Firebaugh
2018-07-23 16:08:44 -07:00
parent cb714d57c5
commit 2bbc792060
15 changed files with 122 additions and 34 deletions

View File

@@ -61,8 +61,11 @@ bool RenderFillLayer::hasTransition() const {
void RenderFillLayer::render(PaintParameters& parameters, RenderSource*) {
if (evaluated.get<FillPattern>().from.empty()) {
for (const RenderTile& tile : renderTiles) {
assert(dynamic_cast<FillBucket*>(tile.tile.getBucket(*baseImpl)));
FillBucket& bucket = *reinterpret_cast<FillBucket*>(tile.tile.getBucket(*baseImpl));
auto bucket_ = dynamic_cast<FillBucket*>(tile.tile.getBucket(*baseImpl));
if (!bucket_) {
continue;
}
FillBucket& bucket = *bucket_;
auto draw = [&] (auto& program,
const auto& drawMode,
@@ -146,8 +149,11 @@ void RenderFillLayer::render(PaintParameters& parameters, RenderSource*) {
parameters.imageManager.bind(parameters.context, 0);
for (const RenderTile& tile : renderTiles) {
assert(dynamic_cast<FillBucket*>(tile.tile.getBucket(*baseImpl)));
FillBucket& bucket = *reinterpret_cast<FillBucket*>(tile.tile.getBucket(*baseImpl));
auto bucket_ = dynamic_cast<FillBucket*>(tile.tile.getBucket(*baseImpl));
if (!bucket_) {
continue;
}
FillBucket& bucket = *bucket_;
auto draw = [&] (auto& program,
const auto& drawMode,