diff --git a/src/mbgl/layout/symbol_feature.hpp b/src/mbgl/layout/symbol_feature.hpp index e16dd0b2f..72f613d4b 100644 --- a/src/mbgl/layout/symbol_feature.hpp +++ b/src/mbgl/layout/symbol_feature.hpp @@ -22,10 +22,15 @@ public: FeatureIdentifier getID() const override { return feature->getID(); }; GeometryCollection getGeometries() const override { return geometry; }; + friend bool operator < (const SymbolFeature& lhs, const SymbolFeature& rhs) { + return lhs.sortKey < rhs.sortKey; + } + std::unique_ptr feature; GeometryCollection geometry; optional formattedText; optional icon; + float sortKey = 0.0f; std::size_t index; }; diff --git a/src/mbgl/layout/symbol_layout.cpp b/src/mbgl/layout/symbol_layout.cpp index badc352f7..03cfe506e 100644 --- a/src/mbgl/layout/symbol_layout.cpp +++ b/src/mbgl/layout/symbol_layout.cpp @@ -96,6 +96,13 @@ SymbolLayout::SymbolLayout(const BucketParameters& parameters, return; } + const bool hasSymbolSortKey = !leader.layout.get().isUndefined(); + const auto symbolZOrder = layout.get(); + const bool sortFeaturesByKey = symbolZOrder != SymbolZOrderType::ViewportY && hasSymbolSortKey; + const bool zOrderByViewportY = symbolZOrder == SymbolZOrderType::ViewportY || (symbolZOrder == SymbolZOrderType::Auto && !sortFeaturesByKey); + sortFeaturesByY = zOrderByViewportY && (layout.get() || layout.get() || + layout.get() || layout.get()); + for (const auto& layer : layers) { layerPaintProperties.emplace(layer->getID(), toRenderSymbolLayer(layer)->evaluated); } @@ -156,7 +163,13 @@ SymbolLayout::SymbolLayout(const BucketParameters& parameters, } if (ft.formattedText || ft.icon) { - features.push_back(std::move(ft)); + if (sortFeaturesByKey) { + ft.sortKey = layout.evaluate(zoom, ft); + const auto lowerBound = std::lower_bound(features.begin(), features.end(), ft); + features.insert(lowerBound, std::move(ft)); + } else { + features.push_back(std::move(ft)); + } } } @@ -541,10 +554,6 @@ std::vector CalculateTileDistances(const GeometryCoordinates& line, const } void SymbolLayout::createBucket(const ImagePositions&, std::unique_ptr&, std::unordered_map>& buckets, const bool firstLoad, const bool showCollisionBoxes) { - const bool zOrderByViewport = layout.get() == SymbolZOrderType::ViewportY; - const bool sortFeaturesByY = zOrderByViewport && (layout.get() || layout.get() || - layout.get() || layout.get()); - auto bucket = std::make_shared(layout, layerPaintProperties, textSize, iconSize, zoom, sdfIcons, iconsNeedLinear, sortFeaturesByY, bucketLeaderID, std::move(symbolInstances), tilePixelRatio); for (SymbolInstance &symbolInstance : bucket->symbolInstances) { @@ -590,7 +599,7 @@ void SymbolLayout::createBucket(const ImagePositions&, std::unique_ptricon.placedSymbols.size() - 1; PlacedSymbol& iconSymbol = bucket->icon.placedSymbols.back(); iconSymbol.vertexStartIndex = addSymbol(bucket->icon, sizeData, *symbolInstance.iconQuad, - symbolInstance.anchor, iconSymbol); + symbolInstance.anchor, iconSymbol, feature.sortKey); for (auto& pair : bucket->paintProperties) { pair.second.iconBinders.populateVertexVectors(feature, bucket->icon.vertices.elements(), {}, {}); @@ -645,7 +654,7 @@ std::size_t SymbolLayout::addSymbolGlyphQuads(SymbolBucket& bucket, } lastAddedSection = symbolQuad.sectionIndex; } - size_t index = addSymbol(bucket.text, sizeData, symbolQuad, symbolInstance.anchor, placedSymbol); + size_t index = addSymbol(bucket.text, sizeData, symbolQuad, symbolInstance.anchor, placedSymbol, feature.sortKey); if (firstSymbol) { placedSymbol.vertexStartIndex = index; firstSymbol = false; @@ -659,7 +668,8 @@ size_t SymbolLayout::addSymbol(SymbolBucket::Buffer& buffer, const Range sizeData, const SymbolQuad& symbol, const Anchor& labelAnchor, - PlacedSymbol& placedSymbol) { + PlacedSymbol& placedSymbol, + float sortKey) { constexpr const uint16_t vertexLength = 4; const auto &tl = symbol.tl; @@ -668,8 +678,10 @@ size_t SymbolLayout::addSymbol(SymbolBucket::Buffer& buffer, const auto &br = symbol.br; const auto &tex = symbol.tex; - if (buffer.segments.empty() || buffer.segments.back().vertexLength + vertexLength > std::numeric_limits::max()) { - buffer.segments.emplace_back(buffer.vertices.elements(), buffer.triangles.elements()); + if (buffer.segments.empty() || + buffer.segments.back().vertexLength + vertexLength > std::numeric_limits::max() || + fabs(buffer.segments.back().sortKey - sortKey) > std::numeric_limits::epsilon()) { + buffer.segments.emplace_back(buffer.vertices.elements(), buffer.triangles.elements(), 0ul, 0ul, sortKey); } // We're generating triangle fans, so we always start with the first diff --git a/src/mbgl/layout/symbol_layout.hpp b/src/mbgl/layout/symbol_layout.hpp index d88c79c55..9b8b0adfc 100644 --- a/src/mbgl/layout/symbol_layout.hpp +++ b/src/mbgl/layout/symbol_layout.hpp @@ -66,7 +66,8 @@ private: const Range sizeData, const SymbolQuad&, const Anchor& labelAnchor, - PlacedSymbol& placedSymbol); + PlacedSymbol& placedSymbol, + float sortKey); // Adds symbol quads to bucket and returns formatted section index of last // added quad. @@ -97,6 +98,7 @@ private: bool sdfIcons = false; bool iconsNeedLinear = false; + bool sortFeaturesByY = false; style::TextSize::UnevaluatedType textSize; style::IconSize::UnevaluatedType iconSize;