From 21e9e0a5eafe494a98ca19babcd650107906510a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Konstantin=20Ka=CC=88fer?= <mail@kkaefer.com>
Date: Fri, 12 Dec 2014 15:01:09 +0100
Subject: [PATCH] set rendering mode so that we can skip intermediate renders
 for static images

---
 include/mbgl/map/map.hpp |  9 ++++++++-
 src/mbgl/map/map.cpp     | 29 ++++++++++++++++-------------
 2 files changed, 24 insertions(+), 14 deletions(-)

diff --git a/include/mbgl/map/map.hpp b/include/mbgl/map/map.hpp
index 245aaf9ea..45846170c 100644
--- a/include/mbgl/map/map.hpp
+++ b/include/mbgl/map/map.hpp
@@ -136,7 +136,14 @@ private:
     // Unconditionally performs a render with the current map state.
     void render();
 
-    bool async = false;
+    enum class Mode : uint8_t {
+        None, // we're not doing any processing
+        Continuous, // continually updating map
+        Static, // a once-off static image.
+    };
+
+    Mode mode = Mode::None;
+
     std::unique_ptr<uv::loop> loop;
     std::unique_ptr<uv::worker> workers;
     std::thread thread;
diff --git a/src/mbgl/map/map.cpp b/src/mbgl/map/map.cpp
index 0af7d4851..1cebb97db 100644
--- a/src/mbgl/map/map.cpp
+++ b/src/mbgl/map/map.cpp
@@ -109,7 +109,7 @@ Map::Map(View& view_, FileSource& fileSource_)
 }
 
 Map::~Map() {
-    if (async) {
+    if (mode == Mode::Continuous) {
         stop();
     }
 
@@ -120,7 +120,6 @@ Map::~Map() {
     style.reset();
     texturePool.reset();
     workers.reset();
-    fileSource.clearLoop();
 
     uv_run(**loop, UV_RUN_DEFAULT);
 }
@@ -134,11 +133,11 @@ uv::worker &Map::getWorker() {
 
 void Map::start() {
     assert(std::this_thread::get_id() == mainThread);
-    assert(!async);
+    assert(mode == Mode::None);
 
     // When starting map rendering in another thread, we perform async/continuously
     // updated rendering. Only in these cases, we attach the async handlers.
-    async = true;
+    mode = Mode::Continuous;
 
     // Reset the flag.
     isStopped = false;
@@ -202,7 +201,7 @@ void Map::start() {
 void Map::stop(std::function<void ()> callback) {
     assert(std::this_thread::get_id() == mainThread);
     assert(mainThread != mapThread);
-    assert(async);
+    assert(mode == Mode::Continuous);
 
     asyncTerminate->send();
 
@@ -222,13 +221,14 @@ void Map::stop(std::function<void ()> callback) {
     // already finished executing.
     thread.join();
 
-    async = false;
+    mode = Mode::None;
 }
 
 void Map::run() {
 #ifndef NDEBUG
-    if (!async) {
+    if (mode == Mode::None) {
         mapThread = mainThread;
+        mode = Mode::Static;
     }
 #endif
     assert(std::this_thread::get_id() == mapThread);
@@ -242,21 +242,24 @@ void Map::run() {
 
     // If the map rendering wasn't started asynchronously, we perform one render
     // *after* all events have been processed.
-    if (!async) {
+    if (mode == Mode::Static) {
         render();
 #ifndef NDEBUG
         mapThread = std::thread::id();
 #endif
+        mode = Mode::None;
+        fileSource.clearLoop();
     }
 }
 
 void Map::rerender() {
-    // We only send render events if we want to continuously update the map
-    // (== async rendering).
-    if (async) {
-        asyncRender->send();
-    } else {
+    if (mode == Mode::Static) {
         prepare();
+    } else if (mode == Mode::Continuous) {
+        // We only send render events if we want to continuously update the map
+        // (== async rendering).
+        assert(asyncRender);
+        asyncRender->send();
     }
 }