[core] Pass a value to response callback, not a reference

This commit is contained in:
John Firebaugh
2015-11-12 17:12:19 -08:00
parent 36581f3d30
commit 1caf89c32b
22 changed files with 45 additions and 56 deletions

View File

@@ -18,7 +18,7 @@ TEST_F(Storage, CacheRevalidateSame) {
const Resource revalidateSame { Resource::Unknown, "http://127.0.0.1:3000/revalidate-same" };
Request* req1 = nullptr;
Request* req2 = nullptr;
req1 = fs.request(revalidateSame, [&](const Response &res) {
req1 = fs.request(revalidateSame, [&](Response res) {
// This callback can get triggered multiple times. We only care about the first invocation.
// It will get triggered again when refreshing the req2 (see below).
static bool first = true;
@@ -35,7 +35,7 @@ TEST_F(Storage, CacheRevalidateSame) {
EXPECT_EQ(0, res.modified);
EXPECT_EQ("snowfall", res.etag);
req2 = fs.request(revalidateSame, [&, res](const Response &res2) {
req2 = fs.request(revalidateSame, [&, res](Response res2) {
if (res2.stale) {
// Discard stale responses, if any.
return;
@@ -81,7 +81,7 @@ TEST_F(Storage, CacheRevalidateModified) {
"http://127.0.0.1:3000/revalidate-modified" };
Request* req1 = nullptr;
Request* req2 = nullptr;
req1 = fs.request(revalidateModified, [&](const Response& res) {
req1 = fs.request(revalidateModified, [&](Response res) {
// This callback can get triggered multiple times. We only care about the first invocation.
// It will get triggered again when refreshing the req2 (see below).
static bool first = true;
@@ -98,7 +98,7 @@ TEST_F(Storage, CacheRevalidateModified) {
EXPECT_EQ(1420070400, res.modified);
EXPECT_EQ("", res.etag);
req2 = fs.request(revalidateModified, [&, res](const Response &res2) {
req2 = fs.request(revalidateModified, [&, res](Response res2) {
if (res2.stale) {
// Discard stale responses, if any.
return;
@@ -142,7 +142,7 @@ TEST_F(Storage, CacheRevalidateEtag) {
const Resource revalidateEtag { Resource::Unknown, "http://127.0.0.1:3000/revalidate-etag" };
Request* req1 = nullptr;
Request* req2 = nullptr;
req1 = fs.request(revalidateEtag, [&](const Response &res) {
req1 = fs.request(revalidateEtag, [&](Response res) {
// This callback can get triggered multiple times. We only care about the first invocation.
// It will get triggered again when refreshing the req2 (see below).
static bool first = true;
@@ -159,7 +159,7 @@ TEST_F(Storage, CacheRevalidateEtag) {
EXPECT_EQ(0, res.modified);
EXPECT_EQ("response-1", res.etag);
req2 = fs.request(revalidateEtag, [&, res](const Response &res2) {
req2 = fs.request(revalidateEtag, [&, res](Response res2) {
if (res2.stale) {
// Discard stale responses, if any.
return;