tei/MapLibreParticleLab
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve handling of cancelled HTTP requests

Browse Source 
Fix a memory leak of NativeMapView Java object
This commit is contained in:
Leith Bade
2015-09-17 17:34:13 -07:00
parent 6e55dd575e
commit 19e7d154bb
4 changed files with 27 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
platform/android/http_request_android.cpp
View File

@@ -75,7 +75,8 @@ private:
static const int connectionError = 0;
static const int temporaryError = 1;
static const int permanentError = 1;
static const int permanentError = 2;
static const int canceledError = 3;
};
// -------------------------------------------------------------------------------------------------
@@ -305,22 +306,26 @@ void HTTPAndroidRequest::onResponse(int code, std::string message, std::string e
}
void HTTPAndroidRequest::onFailure(int type, std::string message) {
if (!response) {
response = std::make_unique<Response>();
}
if (type != canceledError) {
if (!response) {
response = std::make_unique<Response>();
}
response->status = Response::Error;
response->message = message;
response->status = Response::Error;
response->message = message;
switch (type) {
case connectionError:
status = ResponseStatus::ConnectionError;
case temporaryError:
status = ResponseStatus::TemporaryError;
default:
status = ResponseStatus::PermanentError;
switch (type) {
case connectionError:
status = ResponseStatus::ConnectionError;
break;
case temporaryError:
status = ResponseStatus::TemporaryError;
break;
default:
status = ResponseStatus::PermanentError;
}
} else {
status = ResponseStatus::Canceled;
}
async.send();