From 12acd2966488cd96bd9c0dd85359b90630d594d7 Mon Sep 17 00:00:00 2001 From: Bruno de Oliveira Abinader Date: Tue, 14 Jun 2016 16:20:50 +0300 Subject: [PATCH] [tidy/linux] modernize-pass-by-value --- platform/default/http_file_source.cpp | 8 ++++---- src/mbgl/style/sources/geojson_source.cpp | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/platform/default/http_file_source.cpp b/platform/default/http_file_source.cpp index b5d17c761..17e06a6c0 100644 --- a/platform/default/http_file_source.cpp +++ b/platform/default/http_file_source.cpp @@ -63,7 +63,7 @@ public: class HTTPRequest : public AsyncRequest { public: - HTTPRequest(HTTPFileSource::Impl*, const Resource&, FileSource::Callback); + HTTPRequest(HTTPFileSource::Impl*, Resource, FileSource::Callback); ~HTTPRequest() override; void handleResult(CURLcode code); @@ -219,10 +219,10 @@ int HTTPFileSource::Impl::startTimeout(CURLM * /* multi */, long timeout_ms, voi return 0; } -HTTPRequest::HTTPRequest(HTTPFileSource::Impl* context_, const Resource& resource_, FileSource::Callback callback_) +HTTPRequest::HTTPRequest(HTTPFileSource::Impl* context_, Resource resource_, FileSource::Callback callback_) : context(context_), - resource(resource_), - callback(callback_), + resource(std::move(resource_)), + callback(std::move(callback_)), handle(context->getHandle()) { // If there's already a response, set the correct etags/modified headers to make sure we are diff --git a/src/mbgl/style/sources/geojson_source.cpp b/src/mbgl/style/sources/geojson_source.cpp index 01089f2ee..00c344cf0 100644 --- a/src/mbgl/style/sources/geojson_source.cpp +++ b/src/mbgl/style/sources/geojson_source.cpp @@ -64,7 +64,7 @@ GeoJSONSource::GeoJSONSource(std::string id_, std::string url_, std::unique_ptr&& geojsonvt_) : Source(SourceType::GeoJSON, std::move(id_)), - url(url_), + url(std::move(url_)), geojsonvt(std::move(geojsonvt_)) { }