From 1165f62df6dd344d83f88a6396cfba153e9271f3 Mon Sep 17 00:00:00 2001 From: Dane Springmeyer Date: Thu, 15 Aug 2019 14:02:26 -0700 Subject: [PATCH] [core][test] fix leaks from sqlite usage --- platform/default/src/mbgl/storage/sqlite3.cpp | 1 + test/src/mbgl/test/sqlite3_test_fs.cpp | 1 + 2 files changed, 2 insertions(+) diff --git a/platform/default/src/mbgl/storage/sqlite3.cpp b/platform/default/src/mbgl/storage/sqlite3.cpp index 665e23b43..522210f88 100644 --- a/platform/default/src/mbgl/storage/sqlite3.cpp +++ b/platform/default/src/mbgl/storage/sqlite3.cpp @@ -125,6 +125,7 @@ mapbox::util::variant Database::tryOpen(const std::string & const int error = sqlite3_open_v2(filename.c_str(), &db, flags | SQLITE_OPEN_URI, nullptr); if (error != SQLITE_OK) { const auto message = sqlite3_errmsg(db); + sqlite3_close(db); return Exception { error, message }; } return Database(std::make_unique(db)); diff --git a/test/src/mbgl/test/sqlite3_test_fs.cpp b/test/src/mbgl/test/sqlite3_test_fs.cpp index e4f958c90..068ae9e1c 100644 --- a/test/src/mbgl/test/sqlite3_test_fs.cpp +++ b/test/src/mbgl/test/sqlite3_test_fs.cpp @@ -278,6 +278,7 @@ SQLite3TestFS::~SQLite3TestFS() { sqlite3_vfs* test_fs = sqlite3_vfs_find("test_fs"); if (test_fs) { sqlite3_vfs_unregister(test_fs); + sqlite3_free((void*)test_fs); } }