From 0abaae23b69eec1985bd256c6ee1cf50aabe2439 Mon Sep 17 00:00:00 2001 From: Anand Thakker Date: Tue, 28 Mar 2017 07:41:03 -0400 Subject: [PATCH] Small edit to improve code resiliency (#8540) h/t @ChrisLoer catching this place where we were relying on member initialization order. While it _happened_ to be okay here, it's unnecessarily fragile. --- src/mbgl/text/quads.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mbgl/text/quads.cpp b/src/mbgl/text/quads.cpp index 942736208..b13a6a71e 100644 --- a/src/mbgl/text/quads.cpp +++ b/src/mbgl/text/quads.cpp @@ -252,11 +252,12 @@ void getLineGlyphs(std::back_insert_iterator glyphs, const bool glyphIsLogicallyForward = (glyphHorizontalOffsetFromAnchor >= 0) ^ upsideDown; const float glyphDistanceFromAnchor = std::fabs(glyphHorizontalOffsetFromAnchor); + const auto initialSegmentEnd = getSegmentEnd(glyphIsLogicallyForward, line, anchorSegment); VirtualSegment virtualSegment = { anchor.point, - getSegmentEnd(glyphIsLogicallyForward, line, anchorSegment), + initialSegmentEnd, anchorSegment, - getMinScaleForSegment(glyphDistanceFromAnchor, virtualSegment.anchor, virtualSegment.end), + getMinScaleForSegment(glyphDistanceFromAnchor, anchor.point, initialSegmentEnd), std::numeric_limits::infinity() };