From 089ff8e2b34583de6c989c05a0771b108b3c82f0 Mon Sep 17 00:00:00 2001 From: Mikhail Pozdnyakov Date: Tue, 12 Nov 2019 15:43:18 +0200 Subject: [PATCH] No firebase skip for commits touching paths other than darwin-specific --- circle.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/circle.yml b/circle.yml index ad4dc8bfd..c3387aedd 100644 --- a/circle.yml +++ b/circle.yml @@ -516,9 +516,9 @@ commands: - run: name: Check if Firebase should be skipped command: | - SKIPPABLE_TAG=$( git log -1 | grep -ioE -e "\[(skip.firebase|firebase.skip)\]" -e "\[((i|mac)os)+(, (i|mac)os)?\]" -e "\[darwin\]" || true ) - if [ -n "${SKIPPABLE_TAG}" ]; then - echo "Skipping Firebase tests because commit message contained: '${SKIPPABLE_TAG}'" + FIREBASE_TAG=$( git diff origin/$CIRCLE_TARGET_BRANCH... --stat | grep -ivE -e"ios|macos|darwin" || true ) + if [ -z "${FIREBASE_TAG}" ]; then + echo "Skipping Firebase tests because commits changed only Darwin-specific paths." echo 'export SKIP_FIREBASE=1' >> $BASH_ENV fi login-google-cloud-platform: