From 04652b7f4b884f7a868066895178a0d02e034458 Mon Sep 17 00:00:00 2001 From: Mike Morris Date: Fri, 14 Aug 2015 15:09:39 -0400 Subject: [PATCH] fail silently on canceled requests --- src/node_request.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/node_request.cpp b/src/node_request.cpp index b30211e1a..d2cf43790 100644 --- a/src/node_request.cpp +++ b/src/node_request.cpp @@ -58,9 +58,9 @@ v8::Handle NodeRequest::Create(NodeFileSource* source, const mbgl::R NAN_METHOD(NodeRequest::Respond) { auto nodeRequest = ObjectWrap::Unwrap(args.Holder()); - if (!nodeRequest->resource) { - return NanThrowError("Request has already been responded to, or was canceled."); - } + + // Request has already been responded to, or was canceled, fail silently. + if (!nodeRequest->resource) NanReturnUndefined(); auto source = nodeRequest->source; auto resource = std::move(nodeRequest->resource);