From 00308be14093bce1632d2d66e302a35d8a1572b8 Mon Sep 17 00:00:00 2001 From: "Thiago Marcos P. Santos" Date: Fri, 10 Jul 2015 19:24:32 +0300 Subject: [PATCH] Make one arg ctors explicit --- platform/default/asset_request_zip.cpp | 2 +- platform/default/http_request_curl.cpp | 2 +- platform/default/sqlite_cache_impl.hpp | 2 +- src/mbgl/map/tile_worker.cpp | 2 +- src/mbgl/util/worker.cpp | 2 +- src/mbgl/util/worker.hpp | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/platform/default/asset_request_zip.cpp b/platform/default/asset_request_zip.cpp index 7fd93c55d..4c380bdd8 100644 --- a/platform/default/asset_request_zip.cpp +++ b/platform/default/asset_request_zip.cpp @@ -17,7 +17,7 @@ namespace mbgl { class AssetZipContext : public AssetContext { public: - AssetZipContext(uv_loop_t *loop); + explicit AssetZipContext(uv_loop_t *loop); ~AssetZipContext(); RequestBase* createRequest(const Resource& resource, diff --git a/platform/default/http_request_curl.cpp b/platform/default/http_request_curl.cpp index 8599ea05e..b3d6418c0 100644 --- a/platform/default/http_request_curl.cpp +++ b/platform/default/http_request_curl.cpp @@ -60,7 +60,7 @@ class HTTPCURLContext : public HTTPContext { MBGL_STORE_THREAD(tid) public: - HTTPCURLContext(uv_loop_t *loop); + explicit HTTPCURLContext(uv_loop_t *loop); ~HTTPCURLContext(); RequestBase* createRequest(const Resource&, diff --git a/platform/default/sqlite_cache_impl.hpp b/platform/default/sqlite_cache_impl.hpp index 8d90fa881..700771f2e 100644 --- a/platform/default/sqlite_cache_impl.hpp +++ b/platform/default/sqlite_cache_impl.hpp @@ -14,7 +14,7 @@ namespace mbgl { class SQLiteCache::Impl { public: - Impl(const std::string &path = ":memory:"); + explicit Impl(const std::string &path = ":memory:"); ~Impl(); void get(const Resource&, Callback); diff --git a/src/mbgl/map/tile_worker.cpp b/src/mbgl/map/tile_worker.cpp index 6edfe3b1b..15183c0e4 100644 --- a/src/mbgl/map/tile_worker.cpp +++ b/src/mbgl/map/tile_worker.cpp @@ -73,7 +73,7 @@ void TileWorker::redoPlacement(float angle, bool collisionDebug) { template struct PropertyEvaluator { typedef T result_type; - PropertyEvaluator(float z_) : z(z_) {} + explicit PropertyEvaluator(float z_) : z(z_) {} template ::value, int>::type = 0> T operator()(const P &value) const { diff --git a/src/mbgl/util/worker.cpp b/src/mbgl/util/worker.cpp index 1ab6d766f..60adbc803 100644 --- a/src/mbgl/util/worker.cpp +++ b/src/mbgl/util/worker.cpp @@ -14,7 +14,7 @@ namespace mbgl { class Worker::Impl { public: - Impl(FileSource* fs) { + explicit Impl(FileSource* fs) { // FIXME: Workers should not access the FileSource but it // is currently needed because of GlyphsPBF. See #1664. util::ThreadContext::setFileSource(fs); diff --git a/src/mbgl/util/worker.hpp b/src/mbgl/util/worker.hpp index 08fd56497..2d78338db 100644 --- a/src/mbgl/util/worker.hpp +++ b/src/mbgl/util/worker.hpp @@ -16,7 +16,7 @@ class LiveTile; class Worker : public mbgl::util::noncopyable { public: - Worker(std::size_t count); + explicit Worker(std::size_t count); ~Worker(); // Request work be done on a thread pool. Callbacks are executed on the invoking